Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Feature tags not showing up in tag selection UI #5113

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Feb 17, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

The following change caused a regression where tags were not shown here:

image

The code in question looks to try to hide unhealthy tags since they are automated however:

  • Tags come through as an array of ids so the code would have never worked
  • The condition is the wrong way around this would have only shown the unhealthy tags

How did you test this code?

View a feature that has tags and go to the settings tab

@kyle-ssg kyle-ssg requested a review from a team as a code owner February 17, 2025 09:50
@kyle-ssg kyle-ssg requested review from tiagoapolo and matthewelwell and removed request for a team February 17, 2025 09:50
@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Feb 17, 2025
Copy link

vercel bot commented Feb 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 9:52am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 9:52am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Feb 17, 2025 9:52am

@github-actions github-actions bot added the fix label Feb 17, 2025
Copy link
Contributor

github-actions bot commented Feb 17, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5113 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5113 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5113 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5113 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5113 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5113 Finished ✅ Results

@matthewelwell
Copy link
Contributor

This definitely fixes the immediate issue, but it does reveal the unhealthy tag when the feature_health flag is turned off. I think, based on the description of the PR, that is expected, but I'm just mentioning it here for confirmation. We should perhaps work out how to correctly hide this tag when the flag is off (in a separate PR).

image

Copy link
Contributor

github-actions bot commented Feb 17, 2025

Uffizzi Preview deployment-60993 was deleted.

@khvn26 khvn26 changed the title fix: feature tags fix: Feature tags not showing up in tag selection UI Feb 17, 2025
@kyle-ssg kyle-ssg merged commit 3bfcaa6 into main Feb 17, 2025
33 checks passed
@kyle-ssg kyle-ssg deleted the fix/feature-tags branch February 17, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants