fix(edge-identities): prevent unauthorised identity access #5135
+156
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Docker builds report
|
|
Uffizzi Preview |
matthewelwell
commented
Feb 19, 2025
| self.kwargs["identity_uuid"] | ||
| ) | ||
| edge_identity = EdgeIdentity.from_identity_document(identity_document) | ||
| self.check_object_permissions(self.request, edge_identity) |
There was a problem hiding this comment.
This line is the main fix in this PR. There's a lot of other changes here too, mostly related to the refactor implemented to remove this TODO, but I wanted to highlight the actual fix.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5135 +/- ##
==========================================
+ Coverage 97.45% 97.46% +0.01%
==========================================
Files 1216 1224 +8
Lines 42368 42573 +205
==========================================
+ Hits 41289 41495 +206
+ Misses 1079 1078 -1 ☔ View full report in Codecov by Sentry. |
khvn26
reviewed
Feb 19, 2025
api/edge_api/identities/models.py
Outdated
| self._reset_initial_state() # type: ignore[no-untyped-call] | ||
|
|
||
| @classmethod | ||
| def from_identity_document(cls, identity_document: dict) -> "EdgeIdentity": # type: ignore[type-arg] | ||
| return EdgeIdentity(IdentityModel.model_validate(identity_document)) | ||
|
|
||
| @property | ||
| def django_id(self) -> int: | ||
| return self._engine_identity_model.django_id # type: ignore[return-value] | ||
| def django_id(self) -> int: # pragma: no cover |
There was a problem hiding this comment.
Yes, I think so. I removed it.
khvn26
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes permissions on EdgeIdentityViewSet
How did you test this code?
Added / updated tests