Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: feature specific segment creation #5148

Merged
merged 1 commit into from
Feb 20, 2025
Merged

fix: feature specific segment creation #5148

merged 1 commit into from
Feb 20, 2025

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Feb 20, 2025 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • A call to AppActions.getSegmentIdentities was remaining after RTK migration, this removes it as it is no longer needed

How did you test this code?

Create a feature specific segment

@kyle-ssg kyle-ssg requested a review from a team as a code owner February 20, 2025 19:09
@kyle-ssg kyle-ssg requested review from tiagoapolo and removed request for a team February 20, 2025 19:09
@vercel Vercel
Copy link

vercel bot commented Feb 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 7:10pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 7:10pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Feb 20, 2025 7:10pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Feb 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 20, 2025 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5148 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5148 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5148 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5148 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-5148 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-5148 Finished ✅ Results ✅

@kyle-ssg kyle-ssg linked an issue Feb 20, 2025 that may be closed by this pull request
Creating feature-specific segment exits feature details modal #5147
Closed
4 tasks
@kyle-ssg kyle-ssg requested a review from rolodato February 20, 2025 19:10
@kyle-ssg kyle-ssg changed the title fix: feature fix: feature specific segment creation Feb 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 20, 2025 •
edited
Loading

Uffizzi Preview deployment-61164 was deleted.

@kyle-ssg kyle-ssg merged commit 789e394 into main Feb 20, 2025
33 checks passed
@kyle-ssg kyle-ssg deleted the fix/user-specific-segment-creation branch February 20, 2025 19:19
@flagsmithdev flagsmithdev mentioned this pull request Feb 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagoapolo tiagoapolo tiagoapolo approved these changes

@rolodato rolodato Awaiting requested review from rolodato

Assignees
No one assigned
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating feature-specific segment exits feature details modal
2 participants
@kyle-ssg @tiagoapolo