Spelling #2543
Merged
Spelling #2543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
jsoref
commented
Nov 17, 2024
| @@ -8,7 +8,7 @@ on: | |||
| branches: | |||
| - '*' | |||
|
|
|||
| permissions: # limit the permissions of the GITHIUB_TOKEN to reading repository contents | |||
| permissions: # limit the permissions of the GITHUB_TOKEN to reading repository contents | |||
There was a problem hiding this comment.
I'm deleting this file in another PR...
| @@ -19,7 +19,7 @@ class ConventionalCommitFormatterTest( | |||
| arrayOf("feat: Sample", "Features", "Sample"), | |||
| arrayOf("fix: Bug", "Bug Fixes", "Bug"), | |||
| arrayOf("docs: New", "Documentation", "New"), | |||
| arrayOf("refactor: Eveerything", "Refactor", "Eveerything"), | |||
| arrayOf("refactor: Everything", "Refactor", "Everything"), | |||
There was a problem hiding this comment.
This repository didn't seem particularly playful...
| @@ -347,7 +347,7 @@ tasks.test { | |||
| minHeapSize = "512m" | |||
| dependsOn(":resolveArtifacts") | |||
|
|
|||
| // deletes 'results' directory which contains remainings from unit tests | |||
| // deletes 'results' directory which contains remains from unit tests | |||
There was a problem hiding this comment.
alternatively remnants
There was a problem hiding this comment.
I also like "remnants", "leftovers", or "scraps" , but "remains" is funny - so that works.
test_runner/src/test/kotlin/ftl/args/yml/test_error_yaml_cases/flank-no-device-version.yml
Show resolved
Hide resolved
tool/execution/linear/src/main/kotlin/flank/execution/linear/Transform.kt
Show resolved
Hide resolved
kaibolay
previously approved these changes
Nov 19, 2024
tool/execution/linear/src/main/kotlin/flank/execution/linear/Transform.kt
Show resolved
Hide resolved
Signed-off-by: Josh Soref <[email protected]>
kaibolay
previously approved these changes
Nov 19, 2024
kaibolay
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/jsoref/flank/actions/runs/11876519325#summary-33094938650
Note that in addition to spelling fixes, I've included a set of accessibility fixes ...
For more information, see:
I'm happy to split them to a distinct PR (or drop them or anything else).
There's one item which is almost certainly an API break. As with everything else, it can be split out or dropped.
Test Plan
https://github.com/jsoref/flank/actions/runs/11876519448#summary-33094938868
Checklist