-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Exclude certain File Types from the Index search result #2842
feat: Exclude certain File Types from the Index search result #2842
Conversation
z1nc0r3
commented
Jul 16, 2024
- User can add file types through Explorer Settings which should be ignored in search results.
- Partially fixes Exclude certain File Types or directories in the index searching results. #2144 since there was another idea to filter certain folders.
WalkthroughWalkthroughThe changes introduce support for excluding specific file types from search results in the Flow Launcher Explorer plugin. Users can now specify file types to exclude in the plugin settings, enhancing control over search behavior. The implementation includes updates to the settings model, view model, and user interface to accommodate this feature, as well as a new method in the search manager to filter out excluded file types during searches. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant SettingsView
participant SettingsViewModel
participant Settings
participant SearchManager
User->>+SettingsView: Open Settings
SettingsView->>+SettingsViewModel: Display current settings
User->>+SettingsView: Enter excluded file types
SettingsView->>+SettingsViewModel: Update ExcludedFileTypes
SettingsViewModel->>+Settings: Save ExcludedFileTypes
User->>+SearchManager: Perform Search
SearchManager->>+Settings: Get ExcludedFileTypes
SearchManager->>+IsExcludedFile: Check file type
IsExcludedFile-->>SearchManager: Return true/false
SearchManager->>User: Display filtered results
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Is it possible to pass the exclude list when using everything so we don't have to filter the results ourselves? |
Yeah, that would be the best solution here. But it seems there are no such parameters (options) acceps from Everything API as I checked the SDK. |
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
🥷 Code experts: Yusyuriv, onesounds Yusyuriv, onesounds have most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: To learn more about /:\ gitStream - Visit our Docs |