Add Setting for Changing Font in Settings Window #3470
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a configurable font setting specifically for the Settings window to address user requests for accessibility and localization improvements.
- Added a new string property for SettingWindowFont in the ViewModel and the underlying Settings.
- Implemented UI changes including a ComboBox selection handler and immediate font updates.
- Added a reset command and a method for retrieving the system default font.
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Flow.Launcher/ViewModel/SettingWindowViewModel.cs | Added SettingWindowFont property with change notification. |
| Flow.Launcher/SettingWindow.xaml.cs | Imported Media namespace to support font updates. |
| Flow.Launcher/SettingPages/Views/SettingsPaneAbout.xaml.cs | Added a ComboBox selection handler to update the window's font immediately. |
| Flow.Launcher/SettingPages/ViewModels/SettingsPaneAboutViewModel.cs | Added SettingWindowFont property and a reset command for font settings. |
| Flow.Launcher.Infrastructure/UserSettings/Settings.cs | Introduced SettingWindowFont with a default value from GetSystemDefaultFont. |
Files not reviewed (2)
- Flow.Launcher/SettingPages/Views/SettingsPaneAbout.xaml: Language not supported
- Flow.Launcher/SettingWindow.xaml: Language not supported
Flow.Launcher/SettingPages/ViewModels/SettingsPaneAboutViewModel.cs
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull Request Overview
This PR adds an option to change the font used in the Settings window to support accessibility and localization needs. Key changes include:
- Introducing a new SettingWindowFont property (with proper property change notifications) in multiple view models.
- Updating the UI (via an event handler) to immediately reflect the font change.
- Enhancing the helper method GetSystemDefaultFont to accept an optional parameter for using the Noto font.
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Flow.Launcher/ViewModel/SettingWindowViewModel.cs | Added SettingWindowFont property with property change notification. |
| Flow.Launcher/SettingWindow.xaml.cs | Added using directive for System.Windows.Media. |
| Flow.Launcher/SettingPages/Views/SettingsPaneAbout.xaml.cs | Introduced a ComboBox SelectionChanged handler to update the font. |
| Flow.Launcher/SettingPages/ViewModels/SettingsPaneAboutViewModel.cs | Added SettingWindowFont property and a reset command for the font. |
| Flow.Launcher/Infrastructure/Win32Helper.cs | Modified GetSystemDefaultFont to accept a boolean parameter for Noto. |
| Flow.Launcher.Infrastructure/UserSettings/Settings.cs | Added SettingWindowFont property with a default value from Win32Helper. |
Files not reviewed (2)
- Flow.Launcher/SettingPages/Views/SettingsPaneAbout.xaml: Language not supported
- Flow.Launcher/SettingWindow.xaml: Language not supported
Flow.Launcher/SettingPages/ViewModels/SettingsPaneAboutViewModel.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Font settings such as FontFamily are not applied to elements like ComboBox or Button. Since applying this setting for every individual window would require too much work, I’ve decided to skip this part. |
This comment has been minimized.
This comment has been minimized.
|
@coderabbitai Review it please. |
|
🥷 Code experts: Jack251970, Yusyuriv Jack251970, onesounds have most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: To learn more about /:\ gitStream - Visit our Docs |
|
Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX. |
📝 WalkthroughWalkthroughThis change introduces a user-selectable font setting for the application's settings and related windows. A new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant SettingsPaneAboutViewModel
participant Settings
participant Win32Helper
participant UI_Window
User->>UI_Window: Opens Settings/About
UI_Window->>Settings: Get SettingWindowFont
UI_Window->>SettingsPaneAboutViewModel: Bind SettingWindowFont
User->>UI_Window: Selects new font in ComboBox
UI_Window->>SettingsPaneAboutViewModel: Update SettingWindowFont
SettingsPaneAboutViewModel->>Settings: Set SettingWindowFont
Settings->>UI_Window: Notify property changed
UI_Window->>UI_Window: Font updates dynamically
User->>UI_Window: Clicks Reset Font
UI_Window->>SettingsPaneAboutViewModel: ResetSettingWindowFontCommand
SettingsPaneAboutViewModel->>Win32Helper: GetSystemDefaultFont(false)
Win32Helper-->>SettingsPaneAboutViewModel: Return system font
SettingsPaneAboutViewModel->>Settings: Set SettingWindowFont to default
Settings->>UI_Window: Notify property changed
UI_Window->>UI_Window: Font resets to default
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
Flow.Launcher/SettingPages/Views/SettingsPaneAbout.xaml.cs (1)
35-50: Translate Korean comment to English for consistency.The event handler implementation is correct and effectively updates both the model and UI immediately. However, there's a comment in Korean that should be translated to English for consistency.
- // 설정 창 글꼴 즉시 업데이트 + // Immediately update settings window font
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (16)
Flow.Launcher.Infrastructure/UserSettings/Settings.cs(2 hunks)Flow.Launcher.Infrastructure/Win32Helper.cs(1 hunks)Flow.Launcher/CustomQueryHotkeySetting.xaml(1 hunks)Flow.Launcher/CustomQueryHotkeySetting.xaml.cs(2 hunks)Flow.Launcher/CustomShortcutSetting.xaml.cs(2 hunks)Flow.Launcher/Languages/en.xaml(1 hunks)Flow.Launcher/SelectBrowserWindow.xaml(11 hunks)Flow.Launcher/SelectBrowserWindow.xaml.cs(1 hunks)Flow.Launcher/SelectFileManagerWindow.xaml(1 hunks)Flow.Launcher/SelectFileManagerWindow.xaml.cs(1 hunks)Flow.Launcher/SettingPages/ViewModels/SettingsPaneAboutViewModel.cs(1 hunks)Flow.Launcher/SettingPages/Views/SettingsPaneAbout.xaml(2 hunks)Flow.Launcher/SettingPages/Views/SettingsPaneAbout.xaml.cs(2 hunks)Flow.Launcher/SettingWindow.xaml(1 hunks)Flow.Launcher/SettingWindow.xaml.cs(1 hunks)Flow.Launcher/ViewModel/SettingWindowViewModel.cs(2 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (6)
Flow.Launcher/CustomQueryHotkeySetting.xaml.cs (3)
Flow.Launcher/SelectBrowserWindow.xaml.cs (1)
OnPropertyChanged(30-33)Flow.Launcher/SelectFileManagerWindow.xaml.cs (1)
OnPropertyChanged(32-35)Flow.Launcher/CustomShortcutSetting.xaml.cs (1)
OnPropertyChanged(34-37)
Flow.Launcher/SelectFileManagerWindow.xaml.cs (3)
Flow.Launcher/SelectBrowserWindow.xaml.cs (1)
OnPropertyChanged(30-33)Flow.Launcher/CustomQueryHotkeySetting.xaml.cs (1)
OnPropertyChanged(32-35)Flow.Launcher/CustomShortcutSetting.xaml.cs (1)
OnPropertyChanged(34-37)
Flow.Launcher/ViewModel/SettingWindowViewModel.cs (1)
Flow.Launcher.Infrastructure/UserSettings/Settings.cs (1)
Settings(15-438)
Flow.Launcher/SelectBrowserWindow.xaml.cs (3)
Flow.Launcher/SelectFileManagerWindow.xaml.cs (1)
OnPropertyChanged(32-35)Flow.Launcher/CustomQueryHotkeySetting.xaml.cs (1)
OnPropertyChanged(32-35)Flow.Launcher/CustomShortcutSetting.xaml.cs (1)
OnPropertyChanged(34-37)
Flow.Launcher/SettingPages/Views/SettingsPaneAbout.xaml.cs (2)
Flow.Launcher/SettingPages/ViewModels/SettingsPaneAboutViewModel.cs (2)
SettingsPaneAboutViewModel(16-291)SettingsPaneAboutViewModel(78-83)Flow.Launcher/SettingWindow.xaml.cs (2)
SettingWindow(17-205)SettingWindow(22-30)
Flow.Launcher/CustomShortcutSetting.xaml.cs (3)
Flow.Launcher/SelectBrowserWindow.xaml.cs (1)
OnPropertyChanged(30-33)Flow.Launcher/SelectFileManagerWindow.xaml.cs (1)
OnPropertyChanged(32-35)Flow.Launcher/CustomQueryHotkeySetting.xaml.cs (1)
OnPropertyChanged(32-35)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: gitStream.cm
- GitHub Check: gitStream.cm
- GitHub Check: gitStream.cm
- GitHub Check: gitStream.cm
- GitHub Check: build
🔇 Additional comments (25)
Flow.Launcher/Languages/en.xaml (1)
359-359: Good addition of the new setting string resource.The new localization string for "Setting Window Font" has been correctly added to the English language resource dictionary, ensuring the UI has proper text for this new feature.
Flow.Launcher.Infrastructure/Win32Helper.cs (2)
631-640: Well-documented enhancement to the font selection logic.The method signature update with the optional
useNotoparameter is well-documented with XML comments and provides a good default value. This enhancement allows for culture-sensitive font selection.
644-658: Good implementation of culture-aware font selection logic.The implementation correctly checks for Noto fonts matching the current culture by first trying the full language name, then falling back to the language prefix. It also verifies that the font is actually installed on the system before returning it.
Flow.Launcher/SettingWindow.xaml.cs (1)
6-6: Necessary import for font-related functionality.Adding the System.Windows.Media namespace is required to access the FontFamily class and other font-related functionality needed for the new font setting.
Flow.Launcher/SelectFileManagerWindow.xaml (2)
13-13: Good implementation of two-way font binding.The FontFamily property is correctly bound to the SettingWindowFont property with two-way binding, ensuring that font changes will be properly reflected in this window.
1-264:✅ Verification successful
Verify consistent font binding across all relevant windows.
Make sure that similar FontFamily bindings have been added to all other windows that should reflect the font setting (like CustomQueryHotkeySetting.xaml, SelectBrowserWindow.xaml, etc.).
🏁 Script executed:
#!/bin/bash # Check for FontFamily bindings in all XAML files echo "Checking for FontFamily bindings in XAML files..." grep -r "FontFamily=\"{Binding SettingWindowFont" --include="*.xaml" . || echo "No FontFamily bindings found" # Check for SettingWindowFont property implementation in code-behind files echo -e "\nChecking for SettingWindowFont property in code-behind files..." grep -r "SettingWindowFont" --include="*.cs" . | grep -v "Win32Helper.cs" || echo "No SettingWindowFont properties found"Length of output: 4444
Consistent FontFamily Bindings Verified
All relevant XAML windows now include the same FontFamily binding:
- CustomQueryHotkeySetting.xaml
- SelectBrowserWindow.xaml
- SelectFileManagerWindow.xaml
- SettingWindow.xaml
No missing or inconsistent
FontFamily="{Binding SettingWindowFont…}"entries remain.Flow.Launcher/CustomQueryHotkeySetting.xaml (1)
7-7: Good font binding implementation.The addition of FontFamily binding to SettingWindowFont enables dynamic font customization for this window, consistent with the application's new font customization feature.
Flow.Launcher/SettingWindow.xaml (1)
16-16: Good font binding implementation.The addition of FontFamily binding to SettingWindowFont enables dynamic font customization for the settings window, consistent with the application's new font customization feature.
Flow.Launcher/SelectBrowserWindow.xaml (2)
13-13: Good font binding implementation.The addition of FontFamily binding to SettingWindowFont enables dynamic font customization for the browser selection window, consistent with the application's new font customization feature.
58-59: Consistent margin formatting improvement.The margin format has been standardized from comma-separated to space-separated values throughout the XAML, which improves consistency and readability.
Also applies to: 62-62, 77-77, 88-88, 100-101, 104-105, 112-113, 133-134, 151-152, 163-164, 180-182, 188-189, 191-192, 195-196, 201-202, 209-210, 216-217, 219-220, 241-242, 246-247, 252-253
Flow.Launcher.Infrastructure/UserSettings/Settings.cs (1)
99-99: Good implementation of setting window font property.The SettingWindowFont property is correctly initialized with the system default font using the specialized version of GetSystemDefaultFont that can prefer Noto fonts based on culture when the false parameter is passed.
One thing to note is that this property is using a different initialization approach (passing false to GetSystemDefaultFont) compared to other font properties like QueryBoxFont, ResultFont, and ResultSubFont, which don't pass any parameters. This is intentional based on the PR description to provide better font support for localization and accessibility needs.
Flow.Launcher/SelectBrowserWindow.xaml.cs (2)
18-29: LGTM! Property implementation with change notification.The
SettingWindowFontproperty implementation correctly wraps theSettings.SettingWindowFontwith proper change notification logic.
30-33: Well-implemented helper method for property change notifications.This helper method properly encapsulates the property change notification logic, following the same pattern used in other window classes.
Flow.Launcher/SelectFileManagerWindow.xaml.cs (2)
20-31: LGTM! Property implementation with change notification.The
SettingWindowFontproperty implementation correctly wraps theSettings.SettingWindowFontwith proper change notification logic, consistent with the implementation in other window classes.
32-35: Well-implemented helper method for property change notifications.This helper method properly encapsulates the property change notification logic, following the same pattern used in other window classes.
Flow.Launcher/SettingPages/ViewModels/SettingsPaneAboutViewModel.cs (2)
272-283: LGTM! Property correctly implements change notification.The
SettingWindowFontproperty implementation correctly wraps the_settings.SettingWindowFontwith proper change notification.
285-290: Reset command now correctly uses the property setter.The implementation now properly uses the
SettingWindowFontproperty setter rather than directly modifying_settings.SettingWindowFont, ensuring that property change notifications are triggered.Flow.Launcher/SettingPages/Views/SettingsPaneAbout.xaml.cs (1)
1-3: LGTM! Required using directives.These using directives are necessary for the new font selection functionality.
Flow.Launcher/CustomQueryHotkeySetting.xaml.cs (2)
17-35: Clean implementation of INotifyPropertyChanged interfaceThe implementation of the INotifyPropertyChanged interface is correct and follows standard patterns. The property change notification is properly triggered only when the value actually changes.
19-30: Effectively wraps Settings property with change notificationThe SettingWindowFont property correctly wraps the _settings.SettingWindowFont field, ensuring that property change notifications are dispatched when needed. This implementation properly supports the data binding mechanism required for dynamic font updates.
Flow.Launcher/CustomShortcutSetting.xaml.cs (1)
34-37: Correct implementation of OnPropertyChanged methodThe OnPropertyChanged method is implemented correctly with a null-conditional operator to prevent NullReferenceException.
Flow.Launcher/ViewModel/SettingWindowViewModel.cs (1)
49-60: Properly implemented SettingWindowFont property with change notificationThe SettingWindowFont property correctly wraps the _settings.SettingWindowFont with property change notification.
Flow.Launcher/SettingPages/Views/SettingsPaneAbout.xaml (3)
15-19: Well-structured resource setup for system fontsThe CollectionViewSource is an appropriate approach for binding to system fonts.
135-168: Effectively organizes settings with the new ExCardThe UI organization groups related advanced settings together, which is more maintainable. The font selection control provides both a reset button and a dropdown, giving users appropriate options.
One suggestion: Consider adding a tooltip to the Reset button explaining that it will revert to the system default font, as users might not understand exactly what "Reset" means in this context.
-<Button Command="{Binding ResetSettingWindowFontCommand}" Content="Reset" /> +<Button Command="{Binding ResetSettingWindowFontCommand}" Content="Reset" ToolTip="Restore to system default font" />
155-165:✅ Verification successful
Verify font change handling in ComboBox selection
Make sure the
SettingWindowFontComboBox_SelectionChangedevent handler is implemented in the code-behind file to properly handle font changes. This event handler is crucial for applying font changes immediately.Run the following script to verify the event handler implementation:
🏁 Script executed:
#!/bin/bash # Check if the SelectionChanged event handler is implemented echo "Searching for SettingWindowFontComboBox_SelectionChanged implementation..." rg -A 5 "SettingWindowFontComboBox_SelectionChanged" --type csharpLength of output: 875
SelectionChanged event handler is present and wired correctly
TheSettingWindowFontComboBox_SelectionChangedmethod is implemented in SettingsPaneAbout.xaml.cs and updates the view model when a new font is selected. No further action is needed.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a customizable font setting for the Settings window, enabling users to change the font for accessibility or localization reasons. Key changes include:
- Adding a new SettingWindowFont property in various view models and windows.
- Implementing a font reset command in the SettingsPaneAboutViewModel.
- Initializing the default font via an update in Win32Helper and UserSettings.
Reviewed Changes
Copilot reviewed 10 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Flow.Launcher/ViewModel/SettingWindowViewModel.cs | Introduces the SettingWindowFont property with INotifyPropertyChanged implementation. |
| Flow.Launcher/SettingWindow.xaml.cs | Adds the necessary using directive for System.Windows.Media. |
| Flow.Launcher/SettingPages/Views/SettingsPaneAbout.xaml.cs | Implements font update on combo box selection to update the Settings window immediately. |
| Flow.Launcher/SettingPages/ViewModels/SettingsPaneAboutViewModel.cs | Adds the SettingWindowFont property and a reset command for changing the font. |
| Flow.Launcher/SelectFileManagerWindow.xaml.cs | Adds a SettingWindowFont property implementation with property change notifications. |
| Flow.Launcher/SelectBrowserWindow.xaml.cs | Introduces the SettingWindowFont property with its notification logic. |
| Flow.Launcher/CustomShortcutSetting.xaml.cs | Adds a SettingWindowFont property, but the _settings field is declared without initialization. |
| Flow.Launcher/CustomQueryHotkeySetting.xaml.cs | Adds a SettingWindowFont property and the corresponding property change notifications. |
| Flow.Launcher.Infrastructure/Win32Helper.cs | Updates GetSystemDefaultFont to include an optional parameter with XML docs. |
| Flow.Launcher.Infrastructure/UserSettings/Settings.cs | Adds a new SettingWindowFont property with a default value from Win32Helper. |
Files not reviewed (6)
- Flow.Launcher/CustomQueryHotkeySetting.xaml: Language not supported
- Flow.Launcher/Languages/en.xaml: Language not supported
- Flow.Launcher/SelectBrowserWindow.xaml: Language not supported
- Flow.Launcher/SelectFileManagerWindow.xaml: Language not supported
- Flow.Launcher/SettingPages/Views/SettingsPaneAbout.xaml: Language not supported
- Flow.Launcher/SettingWindow.xaml: Language not supported
Comments suppressed due to low confidence (1)
Flow.Launcher/CustomShortcutSetting.xaml.cs:38
- The private readonly _settings field is declared but never initialized in the constructor. Consider assigning it from the provided view model (for example, _settings = vm.Settings) to ensure the SettingWindowFont property works as intended.
public CustomShortcutSetting(SettingsPaneHotkeyViewModel vm)
… SettingWindowViewModel
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@coderabbitai Review it. |
|
Tip For best results, initiate chat on the files or code changes. @onesounds I've reviewed the PR that adds font customization for the Settings window, and I'm impressed with the implementation. The changes are well-structured and thoughtfully designed:
Regarding the limitation of font settings not applying to ComboBox or Button elements - this is a reasonable decision given the complexity it would add to style every individual control. The current approach delivers the key benefits while keeping the implementation scope manageable. Overall, this is a solid implementation that effectively addresses the accessibility and localization needs mentioned in issue #2526. Great work! (_/) If you found this review helpful, would you consider giving us a shout-out on X? Thank you for using CodeRabbit! |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull Request Overview
This PR adds an option to change the font used in the Settings window to support accessibility and localization needs.
- Introduces a new SettingWindowFont property and a reset command in the About settings view model.
- Refactors several view models and settings classes to replace a private _settings field with a public Settings property.
- Updates Win32Helper to support a Noto font lookup via a new method parameter.
Reviewed Changes
Copilot reviewed 8 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Flow.Launcher/ViewModel/SettingWindowViewModel.cs | Exposes the settings instance publicly instead of a private field. |
| Flow.Launcher/SettingPages/ViewModels/SettingsPaneAboutViewModel.cs | Adds SettingWindowFont property and a reset command for font resetting. |
| Flow.Launcher/SelectFileManagerWindow.xaml.cs | Updates the INotifyPropertyChanged implementation with toolkit attribute. |
| Flow.Launcher/SelectBrowserWindow.xaml.cs | Similar update to INotifyPropertyChanged using the toolkit attribute. |
| Flow.Launcher/CustomShortcutSetting.xaml.cs | Refines dependency injection and property initializations. |
| Flow.Launcher/CustomQueryHotkeySetting.xaml.cs | Adjusts settings usage in updating custom hotkeys. |
| Flow.Launcher/Infrastructure/Win32Helper.cs | Modifies GetSystemDefaultFont to include a useNoto parameter. |
| Flow.Launcher/Infrastructure/UserSettings/Settings.cs | Adds the SettingWindowFont property with change notification. |
Files not reviewed (7)
- Flow.Launcher/CustomQueryHotkeySetting.xaml: Language not supported
- Flow.Launcher/CustomShortcutSetting.xaml: Language not supported
- Flow.Launcher/Languages/en.xaml: Language not supported
- Flow.Launcher/SelectBrowserWindow.xaml: Language not supported
- Flow.Launcher/SelectFileManagerWindow.xaml: Language not supported
- Flow.Launcher/SettingPages/Views/SettingsPaneAbout.xaml: Language not supported
- Flow.Launcher/SettingWindow.xaml: Language not supported
Comments suppressed due to low confidence (1)
Flow.Launcher/CustomQueryHotkeySetting.xaml.cs:15
- [nitpick] The flag 'update' is somewhat ambiguous. Consider renaming it to 'isUpdating' (or another descriptive name) to improve code clarity.
private bool update;
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
Jack251970
added
enhancement
What's the PR
Although changing the font of the Settings window is an uncommon requirement, it has been requested multiple times and can be necessary in specific use cases (e.g., accessibility or localization issues).
This PR adds an option to change the font used in the Settings window.
To avoid cluttering the main settings, this option is intentionally placed in a less prominent location.
Todo
This PR continues from #3458.