Fix errors when switching user #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to run a second server will fail unless the user has configured a non-default port. This happens every time a user switches user, because the display manager is implemented as a systemd user session. Use a lock file to avoid that happening. This gets rid of an error message for most users, but forces advanced users to override the systemd configuration. Such users should be smart enough to see the condition failure in the logs, check fluidsynth.service, and understand the hint about `systemctl edit`.
I got the following error while investigating an issue where FluidSynth
failed binding to port 9800:
fluidsynth: error: Failed to bind server socket: 98
It took a long while to realise "98" was an error code, not a sign that
"9800" had been truncated somehow.
Rephrase the errors to avoid confusion.
This is particularly useful when started by systemd. Without this change, the service exits normally without telling systemd it started, leading to an unhelpful "protocol" message from systemd.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fluidsynth includes a systemd user service, which listens on TCP port 9800 by default. So if a computer starts a second user session, that session's service immediately fails because port 9800 is already in use. Lightdm implements its login prompt as a user session, so this can happen just by misclicking the "switch user" button. I assume other display managers are the same, but haven't checked.
This PR is a set of loosely-connected suggestions that would have helped as I went down this particular rabbit hole. I figure they're easier to review together, but happy to edit/split out/remove anything that doesn't fit.