Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Replace - by : during scraping #13

Open
GlazedBelmont opened this issue Jan 25, 2024 · 6 comments
Open

[Feature Request] Replace - by : during scraping #13

GlazedBelmont opened this issue Jan 25, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@GlazedBelmont
Copy link
Contributor

GlazedBelmont commented Jan 25, 2024

A popular method of having : in a filename is replacing it with a - so during scraping, the application asks replaces it with : during its request.
"Captain Toad - Treasure Tracker" -> "Captain Toad: Treasure Tracker"

otherwise IGDB could match false positives and fetch the wrong cover art.
image

@jacobaraujo7 jacobaraujo7 self-assigned this Jan 25, 2024
@jacobaraujo7 jacobaraujo7 added the bug Something isn't working label Jan 25, 2024
@jacobaraujo7
Copy link
Contributor

Today, if you change the title and resync it solves the problem in the scrapper. Wouldn't that be enough?

@GlazedBelmont
Copy link
Contributor Author

GlazedBelmont commented Jan 25, 2024

it does not seem to fix it, it still grabs "Captain Toad Treasure Tracker (2016)"

@jacobaraujo7
Copy link
Contributor

I'm sorry. It may be my English, but I'm having a little trouble understanding it. Could you explain the problem to me again?

@GlazedBelmont
Copy link
Contributor Author

GlazedBelmont commented Jan 26, 2024

image

image

image

@codetrindade
Copy link

I'm sorry. It may be my English, but I'm having a little trouble understanding it. Could you explain the problem to me again?

The concern is that when scraping data from IGDB, some game titles have ':' in their names, but during requests, it's replaced with '-'. For example, 'Captain Toad - Treasure Tracker' becomes 'Captain Toad: Treasure Tracker.' The worry is about potential false positives and fetching incorrect cover art due to this replacement in the request.

@GlazedBelmont
Copy link
Contributor Author

GlazedBelmont commented Jan 30, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants