Conversation
|
could you update the OP with the benchmark result for your system? |
|
we are missing |
| """ | ||
| function gelu(x::RealOrFloatType) | ||
| p = oftype(x / 1, π) | ||
| p = oftype(x / 1, Float64(π)) |
There was a problem hiding this comment.
Why is this hardcoding the type here?
There was a problem hiding this comment.
Zygote willl fail for oftype(..., ::Irrational)
|
Needs testing against Zygote and CUDA to make sure we don't break any dispatch that we are relying on. |
|
Zygote is already tested against here. But testing against CUDA may be out of the scope of NNlib? |
|
Do we need to update the lower bound for the LoopVectorization version in |
|
given #224 and the discussion in FluxML/Flux.jl#1272, I no longer think this is the correct way forward. The whole vectorization logic should live in Flux's layers definitions, and we should revert NNlib to its pre-LoopVectorization state |
|
We should revert the vectorisation stuff and release a patch that drops the packages from dependencies. |
|
Can you also add the same benchmarks using a simple
|
fix #220