Port Information Schema to Sql Server #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudqijawabreh
force-pushed
the
InformationSchemaSqlServer
branch
from
2efd26a to
dc2e2f1
Compare
|
@sudqijawabreh curious how hard would it be to append and not replace ? |
sudqijawabreh
commented
Apr 12, 2021
| @@ -511,15 +514,7 @@ module SqlAnalysis = | |||
| () | |||
| else if not requiredParam.DataType.IsArray then | |||
| match requiredParam.DataType.Name with | |||
| | "bit" -> | |||
There was a problem hiding this comment.
@falfaddaghi this the only part that needs some thought to make it work for both postgres and sql server.
sudqijawabreh
force-pushed
the
InformationSchemaSqlServer
branch
4 times, most recently
from
9cb4ad2 to
890948f
Compare
…t expects one warning message
…xpects one warning message
…ot supported in tsql
…Declaration to fix adjustment issue an issue appears when a var is replaced then another far behind it is replaced doesn't work fine with the adjustment
falfaddaghi
force-pushed
the
InformationSchemaSqlServer
branch
from
890948f to
f246511
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Port Information schema file to support sql server. It is responsible for retrieving database schema and getting query's parameters and output columns. Also modify unit tests to be compatible with sql server