Fix slots 2 #1096
Open
Fix slots 2 #1096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drzel
commented
Feb 26, 2023
csqc/main.qc
Outdated
| local float slotdowns = changed_slots & input_buttons; | ||
| local float slotups = changed_slots & ~input_buttons; | ||
|
|
||
| if (input_slots) { // if using slots, you definitely should be shooting |
There was a problem hiding this comment.
this isn't actually true, e.g. if you're holding +slot3 as a scout or engy, it shouldn't do anything. likewise if the weapon has no ammo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+slotcommand to replace+slot1-4and+quick1-4.This fixes a couple of issues I have with
+slotxaliases / config:+slot1;+slot2;-slot2should return to firing weapon 1, atm it stops shooting.I'm keeping a history of slot changes so I know what to return to.
A future improvement will for it to understand class / ammo and not attempt to fire if there's no weapon / ammo on a given slot.