Add support for windows with MSVC toolchain #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobil4sk
force-pushed
the
feature/msvc-support
branch
from
99bc3dc to
4281b1c
Compare
|
The other windows ci failures seem related to: luarocks/luarocks#1726 |
The patch for the lua compat53 issue has been merged now
tobil4sk
force-pushed
the
feature/msvc-support
branch
from
7f3a448 to
64527bd
Compare
I've upstreamed a patch for this issue, so ci is passing and everything should be working now. |
|
Oh nice! Thanks for contributing. That's not really a use-case I've come across. |
FourierTransformer
merged commit d0baae9
into
FourierTransformer:master
29 checks passed
Thanks! It's useful for being able to install libraries on windows without requiring a mingw environment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only mingw builds are supported via mingw-make. This PR adds support for MSVC using nmake, which luarocks uses by default on MSVC based installations.