-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for parsing OpenStack #1985
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4511db7
to
20803a7
Compare
09e5d73
to
bfd705e
Compare
This PR makes all the necessary handle functions `open` so that someone external to this library can extend and replace this pass, if needed. Furthermore, we make all functions we do NOT wish to be overriden `private` (mostly because we consider them part of a legacy API). Furthermore, this PR adds more documentation to this pass.
…extDFGUntilHit` I am not sure if this really solves *all* the problems, but at least this tries to use the information that we have in the calling context in/out so that we are properly following dataflows into functions and out of functions using the correct call (stack).
97ad65b
to
a54a606
Compare
All PRs are merged, we can close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
publish-to-github-packages
If added to a PR, builds from it will be published as a GitHub package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a union of the following PRs
HasImplicitReceiver
#1984ResolveMemberExpressionAmbiguityPass
now correctly set an FQN in its replaced references #1987followNextDFGUntilHit
#1988SymbolResolver
and make it more extensible #2001It is needed to properly parse the Openstack project with this library. This is needed because of an external dependency that needs one combined branch. This gives us some time to properly review the individual PRs.
We will most likely not merge this PR, but the individual ones and I will regularly update / rebase this branch until all contained PRs are merged.