-
Notifications
You must be signed in to change notification settings - Fork 74
Create a LocalScope
for CollectionComprehensions
and generate a Declaration
#2019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
3387229
Create scope for collection comprehensions
KuechA 209c218
generate local variables in python add declarations pass for comprehe…
KuechA 1ff35b8
Extend test to check fixes
KuechA 501d597
Remove useless flag
KuechA cb0b660
Add test case
KuechA 8b8fccd
Adapt test
KuechA c7893a6
Test resolution of param
KuechA 110c288
Reduce c&p code
KuechA 8011422
add documentation
KuechA 9489ecf
Move applyWithScope to Node
KuechA 091041a
python style
KuechA d75f3f3
Merge branch 'main' into ak/python-comprehension-scope
KuechA 4a53e41
more tests: binding
maximiliankaul 2c17051
Merge branch 'main' into ak/python-comprehension-scope
KuechA b6e7546
Enter scope only for python3
KuechA 485fc73
numbers to text
KuechA a0ff2fb
Test for python2 behavior
KuechA 5dabf21
Document test
KuechA 2408e3f
Leave and re-enter scopes of comprehensions for assign expressions in…
KuechA e24819f
Add test for nested comprehensions with := assignment
KuechA b6e386f
Higher code coverage in test
KuechA e98d6b8
Test version info
KuechA 3529bbb
Extract collection comprehension tests to own file
KuechA deab3da
Rename
KuechA 43c1400
Document test
KuechA 7cca036
Document more asserts and rename wrong variable names
KuechA 97975a3
Document CollectionComprehensionPython3Test.testDictComprehensions
KuechA 96ddeab
Document CollectionComprehensionPython3Test.testSetComprehensions
KuechA 166a638
Document CollectionComprehensionPython3Test.testListComprehensions
KuechA 74f0aa9
Fix error in CollectionComprehensionPython3Test.testListComprehensions
KuechA 86b36cc
Fix style of CollectionComprehensionPython2Test.testComprehensionExpr…
KuechA 0d383fc
Fix tests
KuechA 3b37c2a
Test improvements
KuechA 92ddb45
Remove python2 test
KuechA e55f209
Remove version-based logic which is no longer required
KuechA ddc7ed2
Merge branch 'main' into ak/python-comprehension-scope
KuechA cdb92e8
no more typos
KuechA 4908a5e
object type to primitive type for consistency with other frontends an…
KuechA 2482db0
versionInfo as extension variable
oxisto 10a1603
Merge branch 'main' into ak/python-comprehension-scope
KuechA b4eb266
Revert changes to VersionInfo
KuechA 7de93e2
Merge branch 'main' into ak/python-comprehension-scope
KuechA 31f7377
Add test for write to list index
KuechA 68dc283
Add another test
KuechA 5c9a6af
Add another test: reversed order in tuple
KuechA 4863da8
fix documentation
KuechA f521517
Another test
KuechA cb272ae
Merge branch 'main' into ak/python-comprehension-scope
KuechA edc3170
Another test for more code coverage
KuechA 8707109
Test applyWithScope without ctx
KuechA af9184e
Fix test and typos
KuechA 1ebbc6f
Another assertion
KuechA 20351d3
Add more strict assumptions again
KuechA d4bcd26
Add another test for fields
KuechA 201f026
Comment out failing asserts
KuechA 859cd7f
Merge branch 'main' into ak/python-comprehension-scope
KuechA 0bbb301
Fix test
KuechA File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.