Skip to content

Commit

Permalink
fix(client): Do no longer send TesterPresent in ResponsePending loop
Browse files Browse the repository at this point in the history
We now had multiple occasions where the TesterPresent request with
suppress response bit set triggered a reply by the ECU.
This reply will be treated as the awaited answer of the ResponsePending
loop which cannot be recovered from.

Not sending TesterPresent in the loop also conforms to the UDS standard.
  • Loading branch information
ferdinandjarisch committed Feb 4, 2025
1 parent 1ac3519 commit 7171ca4
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/gallia/services/uds/core/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,6 @@ async def request_unsafe(
raise BrokenPipeError("connection to target lost")
logger.debug(raw_resp.hex(), extra={"tags": ["read", "uds"] + tags})
except TimeoutError as e:
# Send a tester present to indicate that
# we are still there.
# TODO: Is this really necessary?
await self._tester_present(suppress_resp=True)
n_timeout += 1
if n_timeout >= max_n_timeout:
last_exception = MissingResponse(request, str(e))
Expand Down

0 comments on commit 7171ca4

Please sign in to comment.