Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cleanup logger creation #556

Merged
merged 1 commit into from
Jul 21, 2024
Merged

chore: Cleanup logger creation #556

merged 1 commit into from
Jul 21, 2024

Conversation

rumpelsepp
Copy link
Member

@rumpelsepp rumpelsepp commented Jul 17, 2024

Run:

    $ rg -l 'get_logger\(".*"\)' | xargs sed -iE 's|get_logger(".*")|get_logger(__file__)|'

get_logger(__file__) does what you expect without typos.

Run:

        $ rg -l 'get_logger\(".*"\)' | xargs sed -iE 's|get_logger(".*")|get_logger(__file__)|'

get_logger(__file__) does what you expect without typos.
@ferdinandjarisch
Copy link
Contributor

Hm, I seem to remember that in my initial draft of the logging-rework I already took this approach but you/Tobi somehow wanted the hardcoded values... 🤔

Anyhow, haven't tested this, but content-wise it looks fine to me!

@rumpelsepp rumpelsepp merged commit eb79f78 into master Jul 21, 2024
11 checks passed
@rumpelsepp rumpelsepp deleted the logger branch July 21, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants