fix: Let wait_for_ecu() reconnect on all ConnectionErrors incl. hidden #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, a broken transport triggers a reconnect in request_unsafe(), but only in case of retries. Since wait_for_ecu specifically sets retries to 0 this is not happening and instead ConnectionErrors are transformed to UDSExceptions. This commit brings two major changes: 1. `request_unsafe` sets the __cause__ of the MissingResponse to ConnectionError to provide callers with additional information 2. `wait_for_ecu` treats a MissingRespone caused by a ConnectionError the same as a ConnectionError and calls reconnect
rumpelsepp
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a broken transport triggers a reconnect in request_unsafe(), but only in case of retries. Since wait_for_ecu specifically sets retries to 0 this is not happening and instead ConnectionErrors are transformed to UDSExceptions.
This commit brings two major changes:
request_unsafesets the cause of the MissingResponse to ConnectionError to provide callers with additional informationwait_for_ecutreats a MissingRespone caused by a ConnectionError the same as a ConnectionError and calls reconnect