Improve session scanner #682
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current approach does recover the stack on each session change attempt, which greatly prolongs scans in a session that takes some time to get into. From now on, the stack is only recovered when needed, e.g. in case of an error or when a session change attempt was successful.
With the assumption that it does not matter how a session is entered, it is only interesting to know from where one can reach a session. Thus, the better default is to use a fast approach that only scans from each session once in order to find available session transitions. To replicate the old scanning behaviour, --thorough can be specified to scan multiple times from the same session. In order to avoid infinite loops, --depth now has a default value of 4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.