-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Move Top/Bottom to playlist #4604
Add Move Top/Bottom to playlist #4604
Conversation
Thanks for the initiative on this @ArthurKun21! My suggestions (haven't looked into the code yet):
Thanks @ArthurKun21! |
Head branch was pushed to by a user without write access
Just had an idea: changing the original up/down to |
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Left a handful of comments after looking into the code. Thanks @ArthurKun21! |
Head branch was pushed to by a user without write access
I will have to review this after #4597 is merged which introduced pagination for user playlists and test on playlists with > 100 items |
The video thumbnail looks really crowded now. As move to top and move to bottom are presumably used a lot less often than the normal up and down, maybe these two new options should be added to the 3 dots menu? |
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
I noticed a weird glitch in the animation VirtualBoxVM_7OElD5orOG.mp4Also i agree that the thumbnail is too crowded but im not sure if the placement into the 3 dots menu is the right thing to do here. All the playlist related features are accessible in the playlist it self and this one is now a bit tucked away so i would never look in there to find extra options related to playlists Im not sure what the correct placement is, open for suggestions/discussions |
Does this playlist have duplicate videos? |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
I already deleted that playlist but i created a new one without any duplicates an its still doing it. VirtualBoxVM_4sypDgz0Gc.mp4 |
This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
This PR was closed because it has been stalled for 14 days with no activity. |
Add Move Top/Bottom to playlist
Pull Request Type
Related issue
closes #4603
Description
This adds another button to move to Top/Bottom of the playlist
Screenshots
Testing
Desktop
Additional context
This is my first time messing around with javascript/vue. Please forgive some errors if there is any.