-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to remove videos from playlist playback queue #6971
Add option to remove videos from playlist playback queue #6971
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An option to remove from more options
I would like to see this removed as mention in another issue before adding yet another option in the more options menu only overcrowds that menu even more. I think adding the trash icon is more than enough.
Fair. I added it to match how YouTube does it. Just going with Trash Icon would be better. |
Head branch was pushed to by a user without write access
04628e1
to
2632421
Compare
Thinking about this again. I think the behavior of this pr would probably be highly confusing for users. Why?
|
Alright |
Ability to remove videos from playlists while they're in the playback/queue
The changes allow users to:
The functionality matches the existing playlist removal behavior from the main playlist view, but now it's available while watching videos too.
Pull Request Type
Related issue
Closes #6968
Description
can-remove-from-playlist
prop to theft-list-video-numbered
component in the watch video playlist template, which will be true for user playlistsremove-from-playlist
event handler to handle video removalhandleRemoveFromPlaylist
method that:prevVideoBeforeDeletion
Screenshots
An always visible delete icon


An option to remove from more options
Testing
Desktop
Additional context