forked from frappe/helpdesk
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: added missing i18n on string in vue components #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Assignment Rules: Added __ import and translated ticketRoutingOptions - EmailNotifications: Added __ import to Notification.vue - FieldDependency: Translated all user-facing strings in criteria, fields selection, and value selection components - Holiday: Full translation of calendar, list, table view, modals, and recurring holidays components This is part of the effort to add i18n support across the codebase as requested in PR frappe#2836.
- SLA: Translated all modals (EditResponseResolution, WorkDay), list items, priorities, status, workdays, and assignment conditions - Agents: Translated role labels, dropdown options, toast messages - AgentCard: Translated inactive badge - Email: Translated config fields, labels, descriptions, validation messages, and service info texts - InviteAgents: Translated role labels, toast messages - EmailAccountList: Added __ import
- General: Added __ import to LogoUpload and WorkflowKnowledgebaseSettings - Teams: Translated validation messages in NewTeam, button labels in TeamEdit and RenameTeamModal
- AssignmentModal: Translated title and placeholder - ConfirmDialog: Translated confirm button label - ViewModal: Translated title, placeholder, and button labels - TicketMergeModal: Translated all strings and messages - TicketSplitModal: Translated all strings and messages
- CategoryModal: Translated title and action button labels - NewCustomerDialog: Translated title, labels, and messages
- MergeCategoryModal.vue - MoveToCategoryModal.vue - TicketSubjectModal.vue - AddNewAgentsDialog.vue - CustomerDialog.vue - CallLogDetailModal.vue - SettingsModal.vue (add missing import)
- InvalidPage.vue - Contacts.vue - Customers.vue - CallLogs.vue - Articles.vue - KnowledgeBaseCustomer.vue
- TicketConversation.vue - TicketAgent.vue - TicketCustomerTemplateFields.vue
- TicketTextEditor.vue - TicketBreadcrumbs.vue
- Autocomplete.vue - EmptyState.vue - CommunicationArea.vue - TextEditor.vue - EmailEditor.vue
- UniInput.vue - ListRows.vue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting it from a fork of frappe helpdesk,
There's a PR open in the original repo for this changes, but we'll be getting it in our fork, before it gets into develop branch.
frappe#2856