Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Floating checklist #424

Merged
merged 13 commits into from
Feb 6, 2025
Merged

Floating checklist #424

merged 13 commits into from
Feb 6, 2025

Conversation

dfltr
Copy link
Contributor

@dfltr dfltr commented Feb 4, 2025

Changes:

  • Added Checklist.Floating, Popover, Progress.Ring, and useAutoScroll
  • Moved useFloatingHint out to generic useFloating
  • Backported useAutoScroll to Hint

TODO (later):

  • Backport useFloating to Hint

dfltr added 13 commits February 3, 2025 13:53
@dfltr
Temp commit: Initial floating checklist struts
45add65
@dfltr
Return full useFloating object
2863d00
@dfltr
Rework useFloating to allow for nested Popovers, also make a Popover …
6bb9612 
…component, also build out Floating Checklist with nested Popovers.
@dfltr
Temp commit: Mucking around with animation containers
d0caed2
@dfltr
Some Floating style fixes
574b6c2
@dfltr
Handle closing interactions, add checkmark
04b04ed
@dfltr
Fix Floating animation, move animation from Popover to Floating
9cfade3
@dfltr
Progress.Ring component, add default anchor for Floating
3913569
@dfltr
Add part props to Floating, fix jank title/progress
6f86d4f
@dfltr
Fix transform origin when side is top
8c4bdb7
@dfltr
Remove explicit anchors in Popover, fix hella type issues
3de51d7
@dfltr
useAutoScroll, Split Popover out into individual files, added Popover…
8f6d5a1 
….Stories
@dfltr
autoScroll stories, backport useAutoScroll to Hint, fix refs
f288a03
@dfltr dfltr requested a review from christianmat February 4, 2025 23:22
christianmat
christianmat approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@christianmat christianmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 💪

@dfltr
Copy link
Contributor Author

dfltr commented Feb 6, 2025

Manually checked failing test, harmless flake :shipit:

@dfltr dfltr merged commit 3c7396d into main Feb 6, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianmat christianmat christianmat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfltr @christianmat