Skip to content

Commit

Permalink
Switched to packaging.version.parse over the (broken) tuple split
Browse files Browse the repository at this point in the history
  • Loading branch information
jamesbraza committed Feb 27, 2025
1 parent 8369f2a commit 320394b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion trl/models/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
from typing import TYPE_CHECKING, Literal, Optional, Union

from accelerate.utils import is_deepspeed_available
from packaging import version
from transformers import PreTrainedModel, PreTrainedTokenizer

from .modeling_value_head import AutoModelForCausalLMWithValueHead, AutoModelForSeq2SeqLMWithValueHead
Expand Down Expand Up @@ -174,7 +175,7 @@ def add_hooks(model: "DeepSpeedEngine") -> None:
optimizer_offload = model.optimizer
else:
raise NotImplementedError(f"Didn't yet handle optimizer {model.optimizer}.")
if deepspeed.__version__.split(".") >= ("0", "16", "4"):
if version.parse(deepspeed.__version__) >= version.parse("0.16.4"):
# Account for renaming in https://github.com/deepspeedai/DeepSpeed/pull/6847
optimizer_offload._register_deepspeed_module(optimizer_offload.module)
else:
Expand Down

0 comments on commit 320394b

Please sign in to comment.