Removing redundant note from WebGPU #7273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed the page for WebGPU says "All major browser engines are working on implementing this spec. All major browser engines are working on implementing this spec." Hm. The same sentence twice? I came here to fix it. But in JSON, it's only there once. Interesting. Well, this note isn't needed at all in Feb 2025, since seeing feature flags for both WebKit and Gecko browsers tells the same story. So I'm deleting it, expecting that will fix the bug as well.
| @@ -657,7 +657,6 @@ | |||
| "3.0-3.1":"n d #1" | |||
| } | |||
| }, | |||
| "notes":"All major browser engines are working on implementing this spec.", | |||
There was a problem hiding this comment.
I believe it would need to be
"notes":"",
to make the pipeline happy :)
(sadly I can't add it as a proper easy to apply suggestion)
Fixing mistake in P.R.
|
Good catch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the page for WebGPU says "All major browser engines are working on implementing this spec. All major browser engines are working on implementing this spec."
Hm. The same sentence twice? I came here to fix it. But in JSON, it's only there once. Interesting. Well, this note isn't needed at all in Feb 2025, since seeing feature flags for both WebKit and Gecko browsers tells the same story. So I'm deleting it, expecting that will fix the bug as well.