-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R21C: Needed to handle OMPS-LP-N21 #183
Conversation
Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
N21 OMPS-LP also needs to be added to gmao_ozinfo.db (availabla.tbl and active.tbl). It will be identical to the N-SNN OMPS-LP except the start date. @kwargan Kris I have those fixes in my sandbox - not pushed yet since I am having problems running and using these input data files ... see below pls. |
@kwargan Actually: when I try using these in an x-exp like settings, the code crashes in error when trying to read either one of the files in the following obs-classes: BEGIN r21c_npp_ompslp_nc => ompslpnc_npp.%y4%m2%d2.t%h2z.nc For the x-exp I put both N21 and NPP together in the same experiment - the code seems to think the number of levels is 61+61=122 ... I can't put my finger one what could be wrong. I haven't tried in the R21C settings, but I checked the codes for ozone handling and they are the same between the R21C and what I am using for x-exp! |
@kwargan can you point me to the scream experiment? I assume that experiment is using both sources of OMPS-LP?! |
@kwargan I think I found a bug in the reading of the nc ozone files ... |
…rse than that - see PR)
@kwargan I now added to this what I believe is a fix for the issue I had in trying to get more than one source of OMPS-LP processed in the code - just by augmenting the ozinfo table was enough for the code to be unhappy - even when a single source is passed gsi.rc ... the change in the Fortran code here fixes the issue. I am putting this here for M21C and also adding the same change in another PR for 5.41.x |
@kwargan or @elakkraoui Can one of you approve this? This is good by me and I'd like to close on this. |
Hi @mathomp4 , can you please approve this when you have a chance? This has been revised and it's also a part of what I have incorporated in the 5.41.x version of GEOSadas. Thanks. |
Ozinfo file was missing needed components to assimilate OMPS-LP from N21. I also changed the permissions in this file and another - no needed for these text files to be executables.
These are clearly only non-zero differences when data from N21 is available; otherwise, these are zero-diff.
CHANGES AIMED AT R21C BRANCH