Skip to content

build routing_model.F90 with O2 in GNU#1432

Open
weiyuan-jiang wants to merge 1 commit into
developfrom
feature/wjiang/fix_gnu_again
Open

build routing_model.F90 with O2 in GNU#1432
weiyuan-jiang wants to merge 1 commit into
developfrom
feature/wjiang/fix_gnu_again

Conversation

@weiyuan-jiang
Copy link
Copy Markdown
Contributor

@weiyuan-jiang weiyuan-jiang commented May 21, 2026

With O3 level, the gfortran has a bug to vectorize power calculation

The PR is trivially 0-diff for all current GCM tests and most GEOSldas tests.

The PR should be 0-diff for the new LDAS_[*]GLOBAL/model tests that include river routing. In fact, the PR is needed for the LDAS_GNUGLOBAL/model test to run successfully.

@weiyuan-jiang weiyuan-jiang requested review from a team as code owners May 21, 2026 19:21
@gmao-rreichle gmao-rreichle added 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 0 diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix This fixes a bug labels May 21, 2026
@gmao-rreichle gmao-rreichle marked this pull request as draft May 21, 2026 20:13
@mathomp4
Copy link
Copy Markdown
Member

@gmao-rreichle are you testing this? I noticed you changed it to draft

@gmao-rreichle gmao-rreichle marked this pull request as ready for review May 22, 2026 16:01
@gmao-rreichle
Copy link
Copy Markdown
Contributor

@gmao-rreichle are you testing this? I noticed you changed it to draft

Ouch, thanks for noticing. I confused #1430 and #1432. The present PR (1432) can be merged. It's 1430 that's "draft" until we hear from @zyj8881357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 0 diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix This fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants