Handmerge #372 into main#377
Merged
Merged
Conversation
…going on that I do not fully understand yet
* update g5_modules_perl_wrapper script to remove loadmodules option from call to g5_modules * Modified the expand function in Perl_Config.pm so that environment variables will be correctly expanded in the string if the variables are defined. --------- Co-authored-by: rtodling <ricardo.todling@nasa.gov>
# Conflicts: # .gitignore # CHANGELOG.md # GMAO_etc/vED # GMAO_perllib/CMakeLists.txt # GMAO_pyobs/VegType_io.c
Member
Author
|
This is failing because of some straggling GMAO_perllib files. See GEOS-ESM/GMAO_perllib#1 for these. |
mathomp4
added
the
0 diff
sdrabenh
previously approved these changes
Apr 16, 2025
Member
Author
|
GMAO_perllib v1.1.0 is now released. When this is put into GMAO_Shared, we should make a joint PR in GEOSgcm. |
sdrabenh
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a handmerge of #372 from @rtodling into
main. #372 needed this due to conflicts.This should come with GEOS-ESM/GMAO_perllib#1 which will be GMAO_perllib v1.1.0