Add ocean observation scripts directory and initial files#382
Merged
Conversation
Member
|
@lren20 These scripts don't seem to have any connection to CMake and thus are not installed. Do you need assistance with this? |
Author
|
Hi Matt,
I need to upload some scripts that convert gmao ocean observation to jedi format. I want to add a directory having all these scripts under GEOS-ESM/GMAO_Shared. I am a beginner of git right now and was trying to create a branch for this. I probably didn't do it correctly. Can you help me with it? Thanks.
Li
[signature_2207884985]
Li Ren
Senior Scientific Programmer/Analyst
Science Systems and Applications, Inc.
NASA GSFC
GMAO │ Code 610.1
8800 Greenbelt Rd, MD 20771
O : 301.614.5929
C: 443.535.1490
***@***.******@***.***>
…________________________________
From: Matt Thompson ***@***.***>
Sent: Tuesday, June 3, 2025 8:42 AM
To: GEOS-ESM/GMAO_Shared ***@***.***>
Cc: Ren, Li (GSFC-610.1)[SCIENCE SYSTEMS AND APPLICATIONS INC] ***@***.***>; Mention ***@***.***>
Subject: [EXTERNAL] [BULK] Re: [GEOS-ESM/GMAO_Shared] Add ocean observation scripts directory and initial files (PR #382)
CAUTION: This email originated from outside of NASA. Please take care when clicking links or opening attachments. Use the "Report Message" button to report suspicious messages to the NASA SOC.
[https://avatars.githubusercontent.com/u/2982494?s=20&v=4]mathomp4 left a comment (GEOS-ESM/GMAO_Shared#382)<#382 (comment)>
@lren20<https://github.com/lren20> These scripts don't seem to have any connection to CMake and thus are not installed. Do you need assistance with this?
—
Reply to this email directly, view it on GitHub<#382 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A2PRLMKVIGGQYIOJWERAO433BWJ4HAVCNFSM6AAAAAB6OTHQP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMZVGA2TENZZGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Member
|
Oh, no. You did the branch right, it's just the scripts don't go anywhere when you build the model. Here's a question. Let's say we build the model and you have: Would you prefer your scripts to be in: or something like: ? That way they are installed, but sort of "in a different place" for now? |
Author
|
Oh, I see. This is not related to the GEOSgcm or GEOS-S2S, and it is a kind of utility to convert the format of ocean observation from GAMO format to JEDI format. Maybe i didn't put them in the right place. Where should I put it?
Thanks,
Li
[signature_2207884985]
Li Ren
Senior Scientific Programmer/Analyst
Science Systems and Applications, Inc.
NASA GSFC
GMAO │ Code 610.1
8800 Greenbelt Rd, MD 20771
O : 301.614.5929
C: 443.535.1490
***@***.******@***.***>
…________________________________
From: Matt Thompson ***@***.***>
Sent: Tuesday, June 3, 2025 10:49 AM
To: GEOS-ESM/GMAO_Shared ***@***.***>
Cc: Ren, Li (GSFC-610.1)[SCIENCE SYSTEMS AND APPLICATIONS INC] ***@***.***>; Mention ***@***.***>
Subject: [EXTERNAL] [BULK] Re: [GEOS-ESM/GMAO_Shared] Add ocean observation scripts directory and initial files (PR #382)
CAUTION: This email originated from outside of NASA. Please take care when clicking links or opening attachments. Use the "Report Message" button to report suspicious messages to the NASA SOC.
[https://avatars.githubusercontent.com/u/2982494?s=20&v=4]mathomp4 left a comment (GEOS-ESM/GMAO_Shared#382)<#382 (comment)>
Oh, no. You did the branch right, it's just the scripts don't go anywhere when you build the model.
Here's a question. Let's say we build the model and you have:
/path/to/GEOSgcm/install
Would you prefer your scripts to be in:
/path/to/GEOSgcm/install/bin
or something like:
/path/to/GEOSgcm/install/gmao2ioda
?
That way they are installed, but sort of "in a different place" for now?
—
Reply to this email directly, view it on GitHub<#382 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A2PRLMJL6FKNKDBBZRYK75L3BWYZJAVCNFSM6AAAAAB6OTHQP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMZVG4YTKNJXHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Member
|
No. I mean, this is where "shared" code lives. I just am wondering where you'd like them installed to when someone runs I can just come up with something for you if you like and add it to this branch |
Author
|
ok, so If I choose the following as you mentioned in previous email
/path/to/GEOSgcm/install/gmao2ioda
When people download the model using the tag, this will be installed, right? As this is not used in the GEOS system and the output is for JEDI, it might be better not to be installed into the model. Any suggestions?
Thanks,
Li
[signature_2207884985]
Li Ren
Senior Scientific Programmer/Analyst
Science Systems and Applications, Inc.
NASA GSFC
GMAO │ Code 610.1
8800 Greenbelt Rd, MD 20771
O : 301.614.5929
C: 443.535.1490
***@***.******@***.***>
…________________________________
From: Matt Thompson ***@***.***>
Sent: Tuesday, June 3, 2025 10:54 AM
To: GEOS-ESM/GMAO_Shared ***@***.***>
Cc: Ren, Li (GSFC-610.1)[SCIENCE SYSTEMS AND APPLICATIONS INC] ***@***.***>; Mention ***@***.***>
Subject: [EXTERNAL] [BULK] Re: [GEOS-ESM/GMAO_Shared] Add ocean observation scripts directory and initial files (PR #382)
CAUTION: This email originated from outside of NASA. Please take care when clicking links or opening attachments. Use the "Report Message" button to report suspicious messages to the NASA SOC.
[https://avatars.githubusercontent.com/u/2982494?s=20&v=4]mathomp4 left a comment (GEOS-ESM/GMAO_Shared#382)<#382 (comment)>
No. I mean, this is where "shared" code lives. I just am wondering where you'd like them installed to when someone runs make install.
I can just come up with something for you if you like and add it to this branch
—
Reply to this email directly, view it on GitHub<#382 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A2PRLMIZOR5VOZWJPEALJGD3BWZJPAVCNFSM6AAAAAB6OTHQP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMZVG42DAOJUHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Member
|
@lren20 Okay. I've updated the CMake. It should now install. |
sdrabenh
approved these changes
Jun 4, 2025
Author
|
Thank you so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.