Skip to content

Add ocean observation scripts directory and initial files#382

Merged
mathomp4 merged 3 commits into
GEOS-ESM:mainfrom
lren20:GMAO_oceanobs
Jun 4, 2025
Merged

Add ocean observation scripts directory and initial files#382
mathomp4 merged 3 commits into
GEOS-ESM:mainfrom
lren20:GMAO_oceanobs

Conversation

@lren20
Copy link
Copy Markdown

@lren20 lren20 commented Jun 3, 2025

No description provided.

@lren20 lren20 requested review from a team as code owners June 3, 2025 04:18
@mathomp4
Copy link
Copy Markdown
Member

mathomp4 commented Jun 3, 2025

@lren20 These scripts don't seem to have any connection to CMake and thus are not installed. Do you need assistance with this?

@lren20
Copy link
Copy Markdown
Author

lren20 commented Jun 3, 2025 via email

@mathomp4
Copy link
Copy Markdown
Member

mathomp4 commented Jun 3, 2025

Oh, no. You did the branch right, it's just the scripts don't go anywhere when you build the model.

Here's a question. Let's say we build the model and you have:

/path/to/GEOSgcm/install

Would you prefer your scripts to be in:

/path/to/GEOSgcm/install/bin

or something like:

/path/to/GEOSgcm/install/gmao2ioda

?

That way they are installed, but sort of "in a different place" for now?

@lren20
Copy link
Copy Markdown
Author

lren20 commented Jun 3, 2025 via email

@mathomp4
Copy link
Copy Markdown
Member

mathomp4 commented Jun 3, 2025

No. I mean, this is where "shared" code lives. I just am wondering where you'd like them installed to when someone runs make install.

I can just come up with something for you if you like and add it to this branch

@lren20
Copy link
Copy Markdown
Author

lren20 commented Jun 3, 2025 via email

@mathomp4 mathomp4 requested a review from a team as a code owner June 3, 2025 15:47
@mathomp4
Copy link
Copy Markdown
Member

mathomp4 commented Jun 3, 2025

@lren20 Okay. I've updated the CMake. It should now install.

@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Jun 3, 2025
@mathomp4 mathomp4 merged commit 0beaefd into GEOS-ESM:main Jun 4, 2025
5 of 6 checks passed
@lren20
Copy link
Copy Markdown
Author

lren20 commented Jun 4, 2025

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff The changes in this pull request have verified to be zero-diff with the target branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants