Skip to content

Fix for GNU#398

Merged
sdrabenh merged 3 commits into
mainfrom
feature/mmanyin/fix_for_gnu
Jan 6, 2026
Merged

Fix for GNU#398
sdrabenh merged 3 commits into
mainfrom
feature/mmanyin/fix_for_gnu

Conversation

@mmanyin
Copy link
Copy Markdown
Contributor

@mmanyin mmanyin commented Dec 9, 2025

There was a runtime error when compiled with GNU and -fsanitize=leak.
The fix was to recast all vector declarations such as REAL ABC(1) to be instead REAL ABC(*) in sphere.F .
Verified zero-diff for GCM when using the standard ifort compilation.
I recognize that this section of code may be used in several contexts; what other tests are required?

@mmanyin mmanyin requested review from a team as code owners December 9, 2025 18:46
@mmanyin mmanyin added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Dec 9, 2025
@mathomp4
Copy link
Copy Markdown
Member

mathomp4 commented Dec 9, 2025

Mentioning @sdrabenh and @wmputman as they probably go near sphere.F more than any of us.

@sdrabenh sdrabenh merged commit a3c2db3 into main Jan 6, 2026
11 checks passed
@sdrabenh sdrabenh deleted the feature/mmanyin/fix_for_gnu branch January 6, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff The changes in this pull request have verified to be zero-diff with the target branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants