Fix HorzIJ in MAPL3G to get local indices

[bena-nasa]

This fixes the "hozij" routines in MAPL3 so that they now have an option to return the local indices. When they were ported from MAPL2 they were erroneously implement to only give global coordinates. This did require passing the GEOM down to the layer that computes the indices as I need to know the global bounds of the domain to compute the local from the global

I add an option (local_indices, default false) so the user can control which they get. If not passed it still returns the global indices

I added unit tests.

Types of change(s)

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Trivial change (affects only documentation or cleanup)
• Refactor (no functional changes, no api changes)

Checklist

• Tested this change with a run of GEOSgcm
• Ran the Unit Tests (make tests)

Description

Related Issue

[mathomp4]

Looks like GNU is unhappy:

/__w/MAPL/MAPL/build/infrastructure/geom/geom/XY/XYGeomSpec_SMOD_get_horz_ij_index.F90:3:26:

    3 | submodule (mapl_XYGeomSpec) get_horz_ij_index_smod
      |                          1
    4 |    use mapl_ErrorHandlingMod
    5 |    use ESMF, only: ESMF_Geom
      |                            2
Error: Symbol 'esmf_geom' at (1) conflicts with the symbol at (2)
gmake[2]: *** [infrastructure/geom/geom/CMakeFiles/MAPL.geom.dir/build.make:1778: infrastructure/geom/geom/CMakeFiles/MAPL.geom.dir/XY/XYGeomSpec_SMOD_get_horz_ij_index.F90.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....
gmake[1]: *** [CMakeFiles/Makefile2:7764: infrastructure/geom/geom/CMakeFiles/MAPL.geom.dir/all] Error 2
gmake: *** [Makefile:166: all] Error 2

[bena-nasa]

Looks like GNU is unhappy:

/__w/MAPL/MAPL/build/infrastructure/geom/geom/XY/XYGeomSpec_SMOD_get_horz_ij_index.F90:3:26:

    3 | submodule (mapl_XYGeomSpec) get_horz_ij_index_smod
      |                          1
    4 |    use mapl_ErrorHandlingMod
    5 |    use ESMF, only: ESMF_Geom
      |                            2
Error: Symbol 'esmf_geom' at (1) conflicts with the symbol at (2)
gmake[2]: *** [infrastructure/geom/geom/CMakeFiles/MAPL.geom.dir/build.make:1778: infrastructure/geom/geom/CMakeFiles/MAPL.geom.dir/XY/XYGeomSpec_SMOD_get_horz_ij_index.F90.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....
gmake[1]: *** [CMakeFiles/Makefile2:7764: infrastructure/geom/geom/CMakeFiles/MAPL.geom.dir/all] Error 2
gmake: *** [Makefile:166: all] Error 2

ok, I'll try the GNU build, had not tried that

[bena-nasa]

Looks like GNU is unhappy:

/__w/MAPL/MAPL/build/infrastructure/geom/geom/XY/XYGeomSpec_SMOD_get_horz_ij_index.F90:3:26:

    3 | submodule (mapl_XYGeomSpec) get_horz_ij_index_smod
      |                          1
    4 |    use mapl_ErrorHandlingMod
    5 |    use ESMF, only: ESMF_Geom
      |                            2
Error: Symbol 'esmf_geom' at (1) conflicts with the symbol at (2)
gmake[2]: *** [infrastructure/geom/geom/CMakeFiles/MAPL.geom.dir/build.make:1778: infrastructure/geom/geom/CMakeFiles/MAPL.geom.dir/XY/XYGeomSpec_SMOD_get_horz_ij_index.F90.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....
gmake[1]: *** [CMakeFiles/Makefile2:7764: infrastructure/geom/geom/CMakeFiles/MAPL.geom.dir/all] Error 2
gmake: *** [Makefile:166: all] Error 2

ok, I'll try the GNU build, had not tried that

Fixed I think