Skip to content

Replace MAPL_GridCompSpecs_ACG.py with MAPL_GridCompSpecs_ACGv3.py in MAPL3#4966

Open
darianboggs wants to merge 2 commits into
developfrom
feature/wdboggs/acg_build_conversion
Open

Replace MAPL_GridCompSpecs_ACG.py with MAPL_GridCompSpecs_ACGv3.py in MAPL3#4966
darianboggs wants to merge 2 commits into
developfrom
feature/wdboggs/acg_build_conversion

Conversation

@darianboggs
Copy link
Copy Markdown
Contributor

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

For MAPL 3, I created a new script, MAPL_GridCompSpecs_ACGv3.py, to perform automatic code generation, while MAPL 2 continues to use MAPL_GridCompSpecs_ACGv.py for the same function. This prevented merges from MAPL 2 from overwriting the MAPL 3 automatic code generation. This required adding an argument in CMakeLists.txt to specify which ACG to use. Now that MAPL 3 is more mature, and we are not merging from MAPL 2, we no longer need to keep two versions of ACG in MAPL 3.

This PR:

  1. removes the MAPL 2 version of ACG,
  2. renames MAPL_GridCompSpecs_ACGv3.py to MAPL_GridCompSpecs_ACG.py so that the MAPL 3 automatic generation is performed for any existing calls to MAPL_GridCompSpecs_ACG.py
  3. removes the argument in CMakeLists.txt for calling MAPL_GridCompSpecs_ACGv3.py.

Related Issue

@darianboggs darianboggs self-assigned this May 22, 2026
@darianboggs darianboggs added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related labels May 22, 2026
@darianboggs darianboggs requested review from mathomp4 and tclune May 22, 2026 21:46
@darianboggs
Copy link
Copy Markdown
Contributor Author

Added @tclune and @mathomp4 as reviewers for their feedback

@darianboggs darianboggs marked this pull request as ready for review May 22, 2026 21:46
@darianboggs darianboggs requested a review from a team as a code owner May 22, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant