Replace MAPL_GridCompSpecs_ACG.py with MAPL_GridCompSpecs_ACGv3.py in MAPL3#4966
Open
darianboggs wants to merge 2 commits into
Open
Replace MAPL_GridCompSpecs_ACG.py with MAPL_GridCompSpecs_ACGv3.py in MAPL3#4966darianboggs wants to merge 2 commits into
darianboggs wants to merge 2 commits into
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of change(s)
Checklist
make tests)Description
For MAPL 3, I created a new script, MAPL_GridCompSpecs_ACGv3.py, to perform automatic code generation, while MAPL 2 continues to use MAPL_GridCompSpecs_ACGv.py for the same function. This prevented merges from MAPL 2 from overwriting the MAPL 3 automatic code generation. This required adding an argument in CMakeLists.txt to specify which ACG to use. Now that MAPL 3 is more mature, and we are not merging from MAPL 2, we no longer need to keep two versions of ACG in MAPL 3.
This PR:
Related Issue