Automatically set up GMAO_perllib #498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Re-submitted to change source branch)
This PR modifies setup.py to clone and install GMAO_perllib at the g1.0.1 tag upon pip install (see #378). Source files are cloned to src/, and installed to ~/.local/bin` (so ~/.local must exist).
I wasn’t entirely sure how to go about installing the library. I don’t think pip has much capability to elegantly support installing non-python libraries, so this basically just takes the form of a script running in setup.py that manually runs the install commands in the shell. I contemplated installing it to the python virtual environment, but that feels like it could potentially get very messy with different users having different python environment setups. I settled on installing to ~/.local/bin, since I think other swell commands are stored in that directory but I’m unsure of the most ideal location.
This uses the CMakeLists.txt from GMAO_perllib, which uses a command esma_set_this(), which I can’t figure out the nature of. From the comments, it seems to be for interactions with other libraries, so I’ve made it so that line is commented out before running.