Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in docs #500

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Fix broken links in docs #500

merged 3 commits into from
Feb 18, 2025

Conversation

ashiklom
Copy link
Collaborator

Fixes a few broken links in our documentation. These are files that don't / no longer exist or were moved without updates to the corresponding links.

I found these by clicking through the docs by hand. Everything else seems to be fine, but there may be additional broken links in there that I missed.

(A fun little side project would be to write a Python script and GitHub action that scans the docs for broken links...)

@ashiklom ashiklom added bug Something isn't working documentation Improvements or additions to documentation labels Feb 10, 2025
@ashiklom ashiklom requested review from Dooruk and mranst February 10, 2025 12:48
@ashiklom ashiklom self-assigned this Feb 10, 2025
So that it renders more cleanly.
@Dooruk
Copy link
Collaborator

Dooruk commented Feb 18, 2025

@ashiklom is this ready for merge or are you still working on it?

@ashiklom
Copy link
Collaborator Author

Ready for review and, assuming it looks good, merge.

Copy link
Collaborator

@Dooruk Dooruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I am in the process of reviving a cycling tier1 test which includes running the coupled model so will review these again.

@Dooruk
Copy link
Collaborator

Dooruk commented Feb 18, 2025

Question for next time: Is it possible not to trigger Tier 1 actions when only document changes are involved?

@Dooruk Dooruk merged commit 66edd9e into develop Feb 18, 2025
2 checks passed
@Dooruk Dooruk deleted the bugfix/docs-broken-links branch February 18, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants