feat: custom model requests #1950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…requires GH changes to work
In order to enable custom models one needs to be able to query which encoded values are active for which profile in ORS.
We do not want to use lombok in core classes just to spare a setter or getter.
This commit adds a graph-build-time configuration flag to enable custom models for each profile. By default the flag is disabled.
This commit includes substantial refactoring to enable its primary goal of adding an appropriate errer response if a user requests a custom model on a profile that is configured to disallow custom models. Co-authored-by: Jochen Haeussler <[email protected]>
The new configuration flag `allow_custom_models` allows one to disable requests containing custom models even if the graph is prepared to support custom requests, e.g., if someone downloads a prebuilt graph but does not want to permit custom request due to their computational cost.
…yml and ors-config.env
Bumps the npm_and_yarn group with 1 update: [katex](https://github.com/KaTeX/KaTeX). Updates `katex` from 0.16.11 to 0.16.21 - [Release notes](https://github.com/KaTeX/KaTeX/releases) - [Changelog](https://github.com/KaTeX/KaTeX/blob/main/CHANGELOG.md) - [Commits](KaTeX/KaTeX@v0.16.11...v0.16.21) --- updated-dependencies: - dependency-name: katex dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <[email protected]>
also unify the placeholder for profiles in properties and make it readable more informative
Two API tests interfered after rebase du to usage of same routing profile under different conditions.
sfendrich
force-pushed
the
feat/custom-model-requests
branch
from
289bbe5 to
d2e9dcd
Compare
|
This was referenced Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Fixes # .
Information about the changes
Directions requests now support the
custom_modeloption as described in https://github.com/GIScience/graphhopper/blob/ors_4.0/docs/core/custom-models.md