Skip to content

Conversation

@merydian
Copy link
Contributor

@merydian merydian commented Oct 7, 2025

Pull Request Checklist

  • 1. I have rebased the latest version of the main branch into my feature branch and all conflicts
    have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
    [Unreleased] heading.
  • [] 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the ors-config.json file, I have added these to the ors config documentation
    along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset
    (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
    importer etc.), I have generated longer distance routes for the affected profiles with different options
    (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
    points generated from the current live ORS.
    If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage
    and why the change was needed.
  • 13. For changes touching the API documentation, I have tested that the API playground renders correctly.

Fixes #2105.

Information about the changes

  • Key functionality added: export endpoint status is now shown in status endpoint responses.
  • Reason for change: It's nice to know the status of the export endpoint.

Examples and reasons for differences between live ORS routes, and those generated from this pull request

Required changes to ors config (if applicable)

    export:
        enabled: true
        attribution: openrouteservice.org, OpenStreetMap contributors

@github-actions github-actions bot added the fix label Oct 7, 2025
@merydian
Copy link
Contributor Author

merydian commented Oct 7, 2025

I suppose config.yml also needs to be adapted to the change in application.yml. Is there a set workflow for this?

@merydian merydian requested a review from aoles October 7, 2025 07:00
@merydian merydian self-assigned this Oct 7, 2025
@aoles aoles marked this pull request as ready for review October 7, 2025 08:37
@aoles
Copy link
Member

aoles commented Oct 7, 2025

Thank a lot for the PR! ❤️

The update of ors-config.yml is handled automagically by the config-conversion-automation.yml workflow, see commit.

Copy link
Member

@aoles aoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, looks quite good in general 👍

Please have a look at the minor issue below.

Cheers!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2025

@aoles aoles enabled auto-merge October 7, 2025 13:31
Copy link
Member

@aoles aoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the fix! 💪

@aoles aoles merged commit 38da7c2 into main Oct 7, 2025
33 checks passed
@aoles aoles deleted the fix/show-export-in-status branch October 7, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export service not listed on status endpoint

2 participants