Use assembly "displayName" field on View titles (#4819)

GMOD · Feb 9, 2025 · 1746d7e · 1746d7e
1 parent 11563e3
commit 1746d7e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/app-core/src/ui/App/ViewContainerTitle.tsx b/packages/app-core/src/ui/App/ViewContainerTitle.tsx
@@ -1,4 +1,5 @@
 import EditableTypography from '@jbrowse/core/ui/EditableTypography'
+import { getSession } from '@jbrowse/core/util'
 import { Tooltip } from '@mui/material'
 import { observer } from 'mobx-react'
 import { makeStyles } from 'tss-react/mui'
@@ -29,13 +30,14 @@ const ViewContainerTitle = observer(function ({
   view: IBaseViewModel
 }) {
   const { classes } = useStyles()
+  const { assemblyManager } = getSession(view)
   return (
     <Tooltip title="Rename view" arrow>
       <EditableTypography
         value={
           view.displayName ||
           // @ts-expect-error
-          `${view.assemblyNames?.join(',') || 'Untitled view'}${
+          `${view.assemblyNames?.map(r => assemblyManager.get(r)?.displayName).join(',') || 'Untitled view'}${
             view.minimized ? ' (minimized)' : ''
           }`
         }

diff --git a/packages/core/assemblyManager/assembly.ts b/packages/core/assemblyManager/assembly.ts
@@ -231,7 +231,7 @@ export default function assemblyFactory(
        * #getter
        */
       get displayName(): string | undefined {
-        return self.getConf('displayName')
+        return self.getConf('displayName') || self.getConf('name') || ''
       },
       /**
        * #method