Split large range requests to avoid origin limits on overly large range requests on e.g. deep-coverage BAM#5576
Open
cmdcolin wants to merge 1 commit into
Open
Split large range requests to avoid origin limits on overly large range requests on e.g. deep-coverage BAM#5576cmdcolin wants to merge 1 commit into
cmdcolin wants to merge 1 commit into
Conversation
…M loci A contiguous run of uncached chunks was coalesced into one HTTP range request. Over deep-coverage BAM loci this produced ~100MB single requests that some origins (e.g. Google Cloud Storage) reject with HTTP 500. Cap each request at MAX_FETCH_CHUNKS (8MB); the same bytes are fetched, now in parallel via the existing concurrency limiter. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A contiguous run of uncached chunks was coalesced into one HTTP range request. Over deep-coverage BAM loci this produced ~100MB single requests that some origins (e.g. Google Cloud Storage) reject with HTTP 500. Cap each request at MAX_FETCH_CHUNKS (8MB); the same bytes are fetched, now in parallel via the existing concurrency limiter.
Notably, this is not because of 'overmerging chunks' in bam-js, it is because there are actually just very large 'chunks' in the bam file itself
claude code reasoning when asked whether this should be added in bam-js itself (which does not have the 'transport layer' [the fetching], it just says what chunks to fetch and sometimes merges chunks to produce less requests, but this is not related to over merging)