Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/51 backarc fun #52

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Feature/51 backarc fun #52

merged 5 commits into from
Sep 25, 2024

Conversation

chrisdicaprio
Copy link
Collaborator

closes #51

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.99%. Comparing base (220c8a7) to head (b66d669).
Report is 6 commits behind head on pre-release.

Additional details and impacted files
@@               Coverage Diff               @@
##           pre-release      #52      +/-   ##
===============================================
+ Coverage        97.96%   97.99%   +0.02%     
===============================================
  Files               17       17              
  Lines              295      299       +4     
  Branches            49       47       -2     
===============================================
+ Hits               289      293       +4     
- Misses               2        3       +1     
+ Partials             4        3       -1     
Flag Coverage Δ
unittests 97.99% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@chrisbc chrisbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisdicaprio it seems that coverage isn't working properly, perhaps shapely library isn't available in GH ??

@chrisdicaprio
Copy link
Collaborator Author

chrisdicaprio commented Sep 24, 2024

@chrisdicaprio it seems that coverage isn't working properly, perhaps shapely library isn't available in GH ??

I think we've just set coverage checks quite strict and it's complaining that not everything new is tested. I think just this:

+ if TYPE_CHECKING:
!
+     from nzshm_common import CodedLocation

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Did you see it complaining about shapely?

@chrisdicaprio chrisdicaprio merged commit 01cc52f into pre-release Sep 25, 2024
11 checks passed
@chrisdicaprio chrisdicaprio deleted the feature/51-backarc-fun branch September 25, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants