Skip to content

[62] reusable testing workflow #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 27, 2025
Merged

Conversation

voj
Copy link
Collaborator

@voj voj commented Apr 13, 2025

closes #62

@voj voj self-assigned this Apr 13, 2025
@voj voj marked this pull request as ready for review April 13, 2025 21:41
@voj voj requested review from chrisbc and chrisdicaprio April 13, 2025 21:41
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.63%. Comparing base (81eec7e) to head (0371c61).
Report is 12 commits behind head on deploy-test.

Additional details and impacted files
@@               Coverage Diff               @@
##           deploy-test      #64      +/-   ##
===============================================
- Coverage        92.50%   90.63%   -1.88%     
===============================================
  Files               15       16       +1     
  Lines              827      790      -37     
  Branches            71       61      -10     
===============================================
- Hits               765      716      -49     
- Misses              49       67      +18     
+ Partials            13        7       -6     
Flag Coverage Δ
unittests 90.63% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

uses: ./.github/workflows/run-tests.yml
uses: GNS-Science/nshm-github-actions/.github/workflows/python-run-tests.yml@main
with:
operating-systems: "['ubuntu-latest']"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question as toshi-api about only testing on ubuntu and py10

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same answer, we control the environment it's run in, and that's what was tested in the deleted run-tests.yml

@voj voj merged commit 9643fb4 into deploy-test Apr 27, 2025
2 of 3 checks passed
@voj voj deleted the chore/62-reusable-workflow branch April 27, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants