Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to update Attestation Required field with more options #374

Merged
merged 11 commits into from
May 28, 2024

Conversation

khgsa
Copy link
Collaborator

@khgsa khgsa commented May 15, 2024

fixed #357 , #370 , #371 , #375 , #376 , #377 , #378

Also fixed below console error

Error: NG0100: ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value for 'attr.aria-expanded': 'undefined'. Current value: 'false'. Expression location: TopNavbarComponent component. Find more at https://angular.io/errors/NG0100
    at throwErrorIfNoChangesMode (core.mjs:11622:11)
    at bindingUpdated (core.mjs:14851:17)
    at Module.ɵɵattribute (core.mjs:14895:9)
    at TopNavbarComponent_Template (top-navbar.component.html:27:46)

@khgsa khgsa requested a review from hatfieldjm4 May 15, 2024 13:51
Copy link
Collaborator

@hatfieldjm4 hatfieldjm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@khgsa khgsa requested a review from hatfieldjm4 May 28, 2024 11:32
Copy link
Collaborator

@hatfieldjm4 hatfieldjm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@hatfieldjm4 hatfieldjm4 merged commit 10ab624 into master May 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On the IT standards GEAR Manager form, change 'Attestation Required' field to a dropdown with choices
2 participants