DIGITAL-298 CSS Icon URLs

[omerida]

Jira ticket

DIGITAL-298

Purpose

Fix relative links to background images so they work in Drupal.

Includes the following PRs that must be merged first

Deployment and testing

Local Setup

These are CSS changes, you shouldn't need to import config or do a full site-install.

QA/Testing instructions

Visit https://digitalgov.lndo.site/guides/site-scanning and confirm external link icon is appended to the links at the end of the page content.

Checklist for the Developer

• A link to the JIRA ticket has been included above.
• No merge conflicts exist with the target branch.
• Automated tests have passed on this PR.
• A reviewer has been designated.
• Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

• The file changes are relevant to the task objective.
• Code is readable and includes appropriate commenting.
• Code standards and best practices are followed.
• QA/Test steps were successfully completed, if applicable.
• Applicable logs are free of errors.

[mattsqd]

@nick-mon1 @omerida
Can you guys collaborate to figure out the best place for these images?
It's looking for it now in the uswd/img directory, but the external image icon digital/img.
When I moved these over, did I put some images in the wrong directory?
There is also the functionality on the Hugo site, where somehow, all the images in usdws/img get copied to the web root, that's not happening on ours. Does it need to?

[omerida]

Met to untangle this with @nick-mon1 today, takeaways

• The external-link reference should be to the USWDS directory, I will fix that
• The material icons were not copied over, they should be part of the digital.gov img folder. There's only this one icon, and it's used by that one CSS class
• A bunch of USWDS images + subdirectories were copied into the static/digitalgov/img. We have a diff of the two dirs that Nick is going to go through and clean up.

[mattsqd]

Met to untangle this with @nick-mon1 today, takeaways

* The external-link reference should be to the USWDS directory, I will fix that

* The material icons were not copied over, they should be part of the digital.gov img folder. There's only this one icon, and it's used by that one CSS class

* A bunch of USWDS images + subdirectories were copied into the `static/digitalgov/img`. We have a diff of the two dirs that Nick is going to go through and clean up.

Should we wait on merging this then? The external-link.svg is still being looked for in /themes/custom/digital_gov/static/uswds/img/external-link.svg and ours is in /themes/custom/digital_gov/static/digitalgov/img/external-link.svg.

[omerida]

This is good to merge. @mattsqd for the external link, it is supposed to be looking for it in the uswds/ folder. @nick-mon1 is going to delete the duplicates in the digitalgov img folder that should only be in uswds/ (Did I understand that correctly, Nick?)

[nick-mon1]

This is good to merge. @mattsqd for the external link, it is supposed to be looking for it in the uswds/ folder. @nick-mon1 is going to delete the duplicates in the digitalgov img folder that should only be in uswds/ (Did I understand that correctly, Nick?)

Yes, I will create a new PR for this. Thanks for calling this.