Week two assignment #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Week two assignment.
bencomer
reviewed
Jul 26, 2018
| plt.subplot(2,1,1) | ||
| plt.scatter(x,y) | ||
| fit_1 = np.polyfit(x,y,1) | ||
| fit_lin = np.poly1d(fit_1) |
There was a problem hiding this comment.
The assignment requests that you use the curve fit function to fit the cubic. It shouldn't be too difficult, so could you go back and change this to use that function?
bencomer
reviewed
Jul 26, 2018
| #plt.title('x-y curve with Cubic Fit') | ||
|
|
||
| # Compute the area using the composite Simpson's rule. | ||
| area_s = simps(y, dx=0.5) |
There was a problem hiding this comment.
nice! You could also use the quad function. This uses Gaussian Quadrature and works on functions.
bencomer
reviewed
Jul 26, 2018
| h_Linear = BIC(y,fit_lin(x),2) # for 1st order there are two coefficients | ||
| print("h_Linear=",h_Linear) | ||
|
|
||
| h_Cubic = BIC(y,fit_cubic(x),4) # 4 coefiicients for order 3 |
There was a problem hiding this comment.
looks like you caught on to the error I made in recitation, that cubic has 4 parameters, not 3
bencomer
requested changes
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Week two assignment.
Description
Submission of week two assignment showing data plot fit with a linear and a cubic fit.
Weekly Journal
Based on the BIC both the fits are almost identical.
Questions