create-vault now works again #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielCartier
approved these changes
Mar 6, 2025
|
|
||
| // Send the raw transaction | ||
| console.log('Sending raw transaction...'); | ||
| const hash = await walletClient.sendRawTransaction({ |
There was a problem hiding this comment.
weird you have to do it that way, i might add a todo but if it works, 👍
|
|
||
| // Log the transaction receipt for debugging | ||
| elizaLogger.info('Successfully created vault', { | ||
| contractAddress: receipt.contractAddress, | ||
| }); | ||
|
|
||
| // TODO Add viem parsing here |
There was a problem hiding this comment.
don't like my todo? :(
Basically if we parse the logs with viem we can get typing, minor anwyay
| @@ -1,2 +1,2 @@ | |||
| export { depositAction } from './silo-deposit'; | |||
| export { createVaultAction } from './create-vault-test'; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.