-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotation Improvements #6256
Annotation Improvements #6256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Eric. I like the overall approach with annotationAt()
doing the heavy lifting in C++ and then everything else being done on top in Python. And it feels great to be interacting more directly with the annotations in the UI now. Specific comments inline as usual...
47c552a
to
1d8a888
Compare
I have the comments addressed and noted above. There's a couple of additional commits as well :
Ready for a new look! |
Thanks Eric, LGTM! Could you squash down ready for merging please? |
1d8a888
to
3f8e83b
Compare
Squashed and merging! |
3f8e83b
to
15bc013
Compare
This adds a few enhancements to node annotations :
AnnotationsUI.contextMenuSignal()
or get individual annotations from the graph editor-wide annotations gadget usingAnnotationsGadget::annotationAt()
.Checklist