Fix for interactive loader with subscenes #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When polling the interactive loader for an external subscene a temporary interactive loader for the subscene is spawned. Subsequent polls to the main loader will then poll the subscene loader instead of normal behavior until the subscene is completely loaded. A new get_load_step_count() method has been added to the packed_scene class that recursively add together load steps from all of its subscenes load_interactive has been implemented for ResourceFormatImporter load_interactive has been implemented for gd scripts as well The result of this commit is that the interactive loader now loads subscenes in several polls instead of loading the entire subscene in 1 poll. This should result in smoother loading bars and (perhaps more importantly) better background loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: not for merging. i use this PR to review the changes i made