Exit early when decision map is empty

Signed-off-by: Aman Khare <[email protected]>
Gaurav614 · Feb 27, 2024 · 1ca219c · 1ca219c
1 parent b7524ae
commit 1ca219c
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/server/src/main/java/org/opensearch/gateway/BaseGatewayShardAllocator.java b/server/src/main/java/org/opensearch/gateway/BaseGatewayShardAllocator.java
@@ -102,9 +102,12 @@ public void allocateUnassignedBatch(Set<ShardRouting> shardRoutings, RoutingAllo
                     if (decisionMap.containsKey(shard)) {
                         executeDecision(shard, decisionMap.remove(shard), allocation, iterator);
                     }
+                } else {
+                    // no need to keep iterating the unassigned shards, if we don't have anything in decision map
+                    break;
                 }
             } catch (Exception e) {
-                logger.error("Failed to execute decision for shard {} ", shard, e);
+                logger.error("Failed to execute decision for shard {} while initializing", shard, e);
             }
         }
     }