Try and fix Menhir tests#255
Merged
Merged
Conversation
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries and fix the tests that are failing because of the new release of menhir. In practice the tests that fail are the ones that are used to promote new
.messagesfiles, and it happens that these files can be quite sensitive to internal heuristics/choices of menhir (e.g. for the numbering of states, the exact tokens chosen, etc..).To solve that, this PR splits tests in two targets:
@runtesttarget is for all regular tests@messagestarget is there for diffing and promotion of.messagesfilesThe
@messagestarget is now only run in one CI workflow, which has a specific pinned version of menhir.Will close #251