Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitions after selection #39

Open
1 of 2 tasks
MoeNick opened this issue Sep 25, 2024 · 3 comments
Open
1 of 2 tasks

Transitions after selection #39

MoeNick opened this issue Sep 25, 2024 · 3 comments
Assignees

Comments

@MoeNick
Copy link
Contributor

MoeNick commented Sep 25, 2024

Use the loading modal for half of the second.

  • for loading 2 projects at the same time, loading modal for each
  • if only one project loads or change, use the loading modal for that specific project.
@MoeNick MoeNick converted this from a draft issue Sep 25, 2024
@Meriem-BM Meriem-BM moved this from Todo to In Progress in Pairwise RF5 Sep 26, 2024
@Meriem-BM
Copy link
Member

Use the loading modal for half of the second.

  • for loading 2 projects at the same time, loading modal for each[ ] if only one project loads or change, use the loading modal for that specific project.

@MoeNick I don't think it's possible to add loading for each project separately since we load both pairs together. We can only add a loading state for both. WDYT @mmahdigh ?

@mmahdigh
Copy link
Collaborator

Use the loading modal for half of the second.

  • for loading 2 projects at the same time, loading modal for each[ ] if only one project loads or change, use the loading modal for that specific project.

@MoeNick I don't think it's possible to add loading for each project separately since we load both pairs together. We can only add a loading state for both. WDYT @mmahdigh ?

Yeah, we don't know when the next pair comes, whether both projects have changed or only one. The next best thing we can do though:

1- Use the loading modal for both cards when using useGetPairwisePairs
2- Use the loading modal for only the card that's going to (most probably) change when calling getPairwisePairsForProject

P.S: These two endpoints might be a little confusing, the first one (useGetPairwisePairs) returns the next pair of projects with no precondition while the latter (getPairwisePairsForProject) accepts a project id argument and looks for a pair that necessarily has that id as one of the projects in the pair. (used when calling the conflict of interest button).

@MoeNick
Copy link
Contributor Author

MoeNick commented Sep 27, 2024

I meant we do that for each card if possible, choose your best possible solution guys I trust you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged on Production
Development

No branches or pull requests

3 participants