Fix: rating bugs & text modifs #60
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -57,8 +57,8 @@ export default function Home() { | |||
| const { checkLoginFlow } = useAuth(); | |||
| const { address, chainId } = useAccount(); | |||
|
|
|||
| const [rating1, setRating1] = useState<number>(3); | |||
There was a problem hiding this comment.
The default value for stars must be null and if users don't rate a project, it should be sent as null to our backend server.
app/comparison/[category]/page.tsx
Outdated
| @@ -326,8 +327,8 @@ export default function Home() { | |||
| data: { | |||
| project1Id: project1!.id, | |||
| project2Id: project2!.id, | |||
| project1Stars: rating1, | |||
| project2Stars: rating2, | |||
| project1Stars: rating1 || 3, | |||
There was a problem hiding this comment.
Here, it shouldn't be sent as a 3 to the backend if it's a null
There was a problem hiding this comment.
Keep the rating as nullat every stage and just show it as a 0 in Line 546. (something like: rating1 === null ? 0 : rating1)
There was a problem hiding this comment.
@MoeNick mentioned that it still should be sent as 3 as default to backend if it's null.
There was a problem hiding this comment.
Seems @mmahdigh is right @Meriem-BM
If user don’t star, and the project shows up again, it should be grayed out.
Seems the default 3 star is not set in backends but calculated at last step.
Thanks
|
I made those modifications @mmahdigh, you can re-review it |
Related #53 #54 #58 #55 #59 #39