Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit the ranking of a category #6

Closed
8 of 9 tasks
MoeNick opened this issue Oct 10, 2024 · 20 comments
Closed
8 of 9 tasks

Edit the ranking of a category #6

MoeNick opened this issue Oct 10, 2024 · 20 comments
Assignees

Comments

@MoeNick
Copy link
Contributor

MoeNick commented Oct 10, 2024

As a user, I want to edit my voted category and attest again.

Design:

https://www.figma.com/design/tP7Arb2C8aDB05wCVxVVSB/Pairwise-RF6--%3E-Voting-App?node-id=1175-36543&t=YULRHcxIjN0cH8Gc-4

Success Criteria

  • 1. The user sees the list of projects (like ballot) with percentages
  • 2. It has been sorted by high to low by default.
  • 3. They can edit by locking and typing the percentages.
  • 4- Percentages can be locked, Max N-2 of them can be locked at the same time, if N-2 is locked, the other lock icons will be disabled.
  • 5- when changing any % the other unlocked fields will change accordingly based on the weights they have
  • 6- if the user ends up having more than 100% in summation, a toast message is shown accordingly in the summation section.
  • 7. The user can freeze percentages and only drag and drop projects in the given provided allocation.
  • 8- The back button will lead the user back to the categories.
  • 9. Submit Vote will run the attest flow Attest the ranked projects inside a category.  #9
@MoeNick MoeNick converted this from a draft issue Oct 10, 2024
@MoeNick MoeNick changed the title View and edit ranking of a category Edit and attest a ranking of a category. Oct 15, 2024
@MoeNick
Copy link
Contributor Author

MoeNick commented Oct 15, 2024

@Meriem-BM I updated the issue.

CC: @mmahdigh to support and be in the loop.

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 27, 2024

  • 1- I tried to submit vote for this category Governance Leadership but by selecting first project I see 502 error

@Meriem-BM

https://pairwise-rf6-git-staging-general-magic.vercel.app/comparison/OP_STACK_RESEARCH_AND_DEVELOPMENT
Image

@GeneralMagicio GeneralMagicio deleted a comment from maryjaf Oct 27, 2024
@maryjaf
Copy link
Collaborator

maryjaf commented Oct 27, 2024

    1. The user can freeze percentages and only drag and drop projects in the given provided allocation.
  • 2- it hasn't been ready for testing yet

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 27, 2024

  • 5- when changing any % the other unlocked fields will change accordingly based on the weights they have
  • 3- based on this AC, I think when I change the percentage into 0.30 in below screen record the order of this project should be change in the list , am I right? @MoeNick @Meriem-BM
Screen.Recording.2024-10-27.at.5.35.58.PM.mov

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 27, 2024

  • 4- the search engine isn't work
Screen.Recording.2024-10-27.at.5.39.16.PM.mov

@MoeNick
Copy link
Contributor Author

MoeNick commented Oct 27, 2024

for 4- let's remove the search.

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 28, 2024

  • 5- sometimes when I change a percentage of one project, the others isn't updated based on this change and I see an error about summation
    please take a look on below screen record
Screen.Recording.2024-10-28.at.10.36.57.AM.mov

@MoeNick MoeNick changed the title Edit and attest a ranking of a category. Edit the ranking of a category Oct 28, 2024
@MoeNick
Copy link
Contributor Author

MoeNick commented Oct 28, 2024

If you want I can exclude the drag and drop from this issue to make us safe for the launch, then we have to remove the drag icon. @Meriem-BM

@MoeNick
Copy link
Contributor Author

MoeNick commented Oct 29, 2024

Can you check this @maryjaf ?

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 29, 2024

  • 5- when changing any % the other unlocked fields will change accordingly based on the weights they have
  • 3- based on this AC, I think when I change the percentage into 0.30 in below screen record the order of this project should be change in the list , am I right? @MoeNick @Meriem-BM

Screen.Recording.2024-10-27.at.5.35.58.PM.mov

@MoeNick @Meriem-BM
Is it in the scope ?

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 29, 2024

In the budget edit, we don't allow the user to lock more than n-2 categories.

However, in the category edit, we only display an error message but still allow the user to lock the category.

budget:

Screen.Recording.2024-10-29.at.8.18.07.PM.mov

category:

Screen.Recording.2024-10-29.at.8.11.34.PM.mov

@Meriem-BM @MoeNick

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 30, 2024

In the budget edit, we don't allow the user to lock more than n-2 categories.

However, in the category edit, we only display an error message but still allow the user to lock the category.

budget:

Screen.Recording.2024-10-29.at.8.18.07.PM.mov
category:

Screen.Recording.2024-10-29.at.8.11.34.PM.mov
@Meriem-BM @MoeNick

@Meriem-BM @MoeNick Kindly reminder

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 30, 2024

  • 5- when changing any % the other unlocked fields will change accordingly based on the weights they have
  • 3- based on this AC, I think when I change the percentage into 0.30 in below screen record the order of this project should be change in the list , am I right? @MoeNick @Meriem-BM
    Screen.Recording.2024-10-27.at.5.35.58.PM.mov

@MoeNick @Meriem-BM Is it in the scope ?

kindly remonder

@Meriem-BM
Copy link
Member

  • 5- when changing any % the other unlocked fields will change accordingly based on the weights they have
  • 3- based on this AC, I think when I change the percentage into 0.30 in below screen record the order of this project should be change in the list , am I right? @MoeNick @Meriem-BM

Screen.Recording.2024-10-27.at.5.35.58.PM.mov

Should it be changed on the view before submitting @MoeNick ?

@MoeNick
Copy link
Contributor Author

MoeNick commented Oct 30, 2024

  • 5- when changing any % the other unlocked fields will change accordingly based on the weights they have
  • 3- based on this AC, I think when I change the percentage into 0.30 in below screen record the order of this project should be change in the list , am I right? @MoeNick @Meriem-BM

Screen.Recording.2024-10-27.at.5.35.58.PM.mov

Should it be changed on the view before submitting @MoeNick ?

If you're mentioning re-ordering when typing, it's not needed and actually not a good UX. We can skip and consult with design team first @Meriem-BM

@Meriem-BM
Copy link
Member

In the budget edit, we don't allow the user to lock more than n-2 categories.

However, in the category edit, we only display an error message but still allow the user to lock the category.

budget:

Screen.Recording.2024-10-29.at.8.18.07.PM.mov
category:

Screen.Recording.2024-10-29.at.8.11.34.PM.mov
@Meriem-BM @MoeNick

@maryjaf you can test this one

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 30, 2024

I got new error by taping on vote
By tapping on connect button in email modal I redirected to the first page and I couldn't complete the ranking flow

Screen.Recording.2024-10-30.at.9.54.27.PM.mov

image

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 30, 2024

In the budget edit, we don't allow the user to lock more than n-2 categories.
However, in the category edit, we only display an error message but still allow the user to lock the category.
budget:
Screen.Recording.2024-10-29.at.8.18.07.PM.mov
category:
Screen.Recording.2024-10-29.at.8.11.34.PM.mov
@Meriem-BM @MoeNick

@maryjaf you can test this one

Thanks @Meriem-BM It has been fixed

@maryjaf maryjaf moved this from On Staging / QA to Approved by QA in Pairwise RF6 Oct 30, 2024
@MoeNick
Copy link
Contributor Author

MoeNick commented Nov 5, 2024

The padding issue has been resolved, thanks @Meriem-BM , but I can see some odd alignment issues for some projects
Image
Image

@MoeNick MoeNick moved this from In Progress to On Staging / QA in Pairwise RF6 Nov 12, 2024
@MoeNick
Copy link
Contributor Author

MoeNick commented Nov 12, 2024

it's on prod, but worth to check it one more time @maryjaf

@maryjaf maryjaf closed this as completed by moving to Approved by QA in Pairwise RF6 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Approved by QA
Development

No branches or pull requests

3 participants